Thunderbottom / UltimateBrowserProject

android browser based on webview
http://bit.ly/XDAUBP
162 stars 59 forks source link

TO DO #69

Closed xdevs23 closed 8 years ago

xdevs23 commented 8 years ago

Here is everything what needs to be done and what has been recently finished.

Use following formatting:

 - [ ] something to do
 - [x] something finished

Just edit this comment and change the content below:


TO DO:

To fix:

To do:

Code status: Waiting for native updater to be completed and bugs to be fixed

Recol commented 8 years ago

I also prefer the second, however the "todo" should be changed to "to do".

xdevs23 commented 8 years ago

Done

Thunderbottom commented 8 years ago

Gonna add more when I find more.

xdevs23 commented 8 years ago

Yep

xdevs23 commented 8 years ago

Added issue

xdevs23 commented 8 years ago

Many things fixed and improved

Thunderbottom commented 8 years ago

Are we ready to release a beta?

xdevs23 commented 8 years ago

A beta, of course.

Thunderbottom commented 8 years ago

Website in Fullscreen mode still shows about:blank at the bottom while scrolling

xdevs23 commented 8 years ago

Oh did not test full screen mode. Will fix it.

Thunderbottom commented 8 years ago

4 more days and I'm done with finals :)

xdevs23 commented 8 years ago

Cool, in the next week, beginning on wednesday, I have holidays. Much more time for coding.

Thunderbottom commented 8 years ago

Well so we can be sure that one version will be released in about a week from now, maybe even earlier!

xdevs23 commented 8 years ago

Yes, I think so.

xdevs23 commented 8 years ago

@Thunderbottom beta can be released now, can't it?

Thunderbottom commented 8 years ago

I'm sick I'll check later tomorrow. Good job, though :)

xdevs23 commented 8 years ago

Yep, thanks.

Thunderbottom commented 8 years ago

Alright so I got someone to test it and they sent me this - screenshot_2015-12-23-14-20-37

Plus the app force closes like "Unfortunately UBP has stopped" when you press the minimize button, have you messed with the onPause method?

Thunderbottom commented 8 years ago

Stack Trace for some help :

Fatal Exception: java.lang.RuntimeException: Unable to start service io.github.UltimateBrowserProject.Service.HolderService@ea08a7e with null: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String io.github.UltimateBrowserProject.b.a.b()' on a null object reference
       at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3071)
       at android.app.ActivityThread.-wrap17(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1461)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:148)
       at android.app.ActivityThread.main(ActivityThread.java:5466)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
       at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:114)
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String io.github.UltimateBrowserProject.b.a.b()' on a null object reference
       at io.github.UltimateBrowserProject.Service.HolderService.onStartCommand(Unknown Source)
       at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3054)
       at android.app.ActivityThread.-wrap17(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1461)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:148)
       at android.app.ActivityThread.main(ActivityThread.java:5466)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
       at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:114)
Thunderbottom commented 8 years ago

Also, I've invited you to our crashlytics page, check your mail.

Thunderbottom commented 8 years ago

Removed "Clear cache when app starts up" cause it's pretty much unwanted.

Thunderbottom commented 8 years ago

Ok, so the app crash no longer occurs, guess I want a commit behind on my PC. But the floating omnibox is still there, and it happens while typing.

xdevs23 commented 8 years ago

Well, I didn't get any crashes in the latest commit.

Your crash came from HolderService.onStartCommand

Thunderbottom commented 8 years ago

Yes, it's not happening now. But the bottom omnibox bug still persists.

xdevs23 commented 8 years ago

I think that is device-dependent.

On my device it doesn't happen at all, in genymotion only when the keyboard is showed.

xdevs23 commented 8 years ago

I will try to make it device-independent

xdevs23 commented 8 years ago

And please don't minify the application if you want to debug it and only build in debug mode so in the stack trace is the exact line of code where the exception happened.

xdevs23 commented 8 years ago

@Thunderbottom are we going to release a beta or a new stable version? Let me know, because we need to change AppConfig.java if it is stable version.

Thunderbottom commented 8 years ago

Beta probably, we'll stick to beta forever until I become better at this. :)

Thunderbottom commented 8 years ago

This thing is for learning only, the main stuff is coming when I'm done learning

xdevs23 commented 8 years ago

Allright. I also am still learning. :D

Would you like a good updater?

I already have made two of them for me, and if you want, I can integrate it into UBP.

Checking for updates, downloading them and installing is all done automatically.

If the device is rooted, it can install directly without user interaction, if not, the user will be prompted in the package installer to update the application.

Sounds cool, what?

xdevs23 commented 8 years ago

But let us first release our new beta :D

Thunderbottom commented 8 years ago

Damn that's cool, I'd like to check the source do you have it on your Git?

Thunderbottom commented 8 years ago

I did one that would check for updates and notify, but that's all that it would do. I linked directly to the apk so it downloaded the update apk and let users install it manually.

Thunderbottom commented 8 years ago

Your updater might be useful for weekly updates that I'm planning to do from January

xdevs23 commented 8 years ago

No, I don't have published the source.

But I can start implementing it after you released the beta.

xdevs23 commented 8 years ago

Did you test the build already?

Thunderbottom commented 8 years ago

I'm doing it right now

xdevs23 commented 8 years ago

Ok, tell me how it goes then.

Thunderbottom commented 8 years ago

Sure, I'm out tomorrow but expect the version to be out by this time, tomorrow. Good job.

xdevs23 commented 8 years ago

Allright, thank you.

xdevs23 commented 8 years ago

@Thunderbottom I am being spammed by Crashlytics with issues 😂😂

Thunderbottom commented 8 years ago

Oh just disable the email notifications.

Thunderbottom commented 8 years ago

You still haven't accepted the invitation according to crashlytics...

xdevs23 commented 8 years ago

I think I did accept it....

Thunderbottom commented 8 years ago

I made you the admin right now

xdevs23 commented 8 years ago

Lol I cannot login into my fabric account anymore 😂

xdevs23 commented 8 years ago

It says wrong email or password but I am sure that I entered the correct one... Let me reset it...

xdevs23 commented 8 years ago

Well, i need to wait 45 minutes now before my account is unlocked

Thunderbottom commented 8 years ago

LMAO.