search

Thutmose / Pokecube

Primary Development has moved to: https://github.com/Pokecube-Development
https://github.com/Pokecube-Development
19 stars 7 forks source link

Embedded Baubles #1

Closed Nerdpie closed 8 years ago

Nerdpie commented 8 years ago

I tried launching an instance of 1.8.8 with Pokécube installed, and Minecraft complained about having two copies of Baubles. I checked, and I have a copy under mods/1.8.8, and there is a copy bundled in the Pokécube Core JAR. This shouldn't be an issue right now, but once other mods start updating, you will VERY quickly run into API conflicts; you should probably list Baubles as a dependency without bundling it. Just a quick heads-up!

Thutmose commented 8 years ago

ahh, baubles is updated to 1.8.8? I will remove it from pokecube if this is the case, as mentioned at the bottom of the readme.

Edit: if you can direct me to the 1.8.8 version of baubles, I will swap over to using it, until then, it will be included.

Nerdpie commented 8 years ago

Yeah, hadn't seen the readme until later. I don't know if it's officially supported or not, though; I mostly had taken a number of mods from a 1.8 instance and tried to launch under 1.8.8. Bauble was one of the ones that didn't complain.

Thutmose commented 8 years ago

oh, if the 1.8 version works, then I will try using it. I will test that asap.

Thutmose commented 8 years ago

Seems it might work indeed, I will remove the included version.

edit I will be releasing an update tomorrow or the next day, whenever I get the last 50ish pokemon animated, with that release, baubles will no longer be included.

I will close this issue once that is out, will leave it open in the meantime incase anyone else has the same issue.

Nerdpie commented 8 years ago

Cool; I look forward to it. I have been running into some crashes, but I'm not sure what level the issues are (MC, Forge, another mod, etc.), especially since I got some crashes before I even added Pokécube; I may pull it into a dev environment and poke around a bit tomorrow.

Thutmose commented 8 years ago

Baubles is officially for 1.8.8 now, I have uploaded a release which removes it from pokecube.

Nerdpie commented 8 years ago

Quick follow up: It works great... after you grab the right resources :facepalm:. I love the timing of the Baubles update too.

Thutmose commented 8 years ago

by the way, this resource pack contains the sounds, and all of the mobs: http://minecraft.curseforge.com/projects/pokecube-resources/files

Nerdpie commented 8 years ago

Cool. I hadn't seen that yesterday when I checked; I'll switch to that after work.