search

Thutmose / Pokecube

Primary Development has moved to: https://github.com/Pokecube-Development
https://github.com/Pokecube-Development
19 stars 7 forks source link

support for LuckPerms #236

Closed smmmadden closed 6 years ago

smmmadden commented 6 years ago

I've tried a few permission mods and ThutPerms seems to be the only one that I can get working with this mod. I tried PEX and spent today trying to get LuckPerms working with no success. All the permission nodes I had previously were added to LP but when I logged in as a player and and OP'd admin, none of the perms were available. Can you add the support for this? LuckPerms-Sponge-4.0.35.jar SpongeForge-1.12.2-2529-7.0.0-BETA-2748.jar Waterfall-Build62.jar

Other mods looking for this to support: image Thanks -Steve

Thutmose commented 6 years ago

Any permissions for command use should be handled by the permissions plugin, does LP have any information about modifying permissions for modded commands?

Thutmose commented 6 years ago

I tested with latest spongeforge and LP, and permissions work fine.

I tested: /luckperms user Thutmose permission set pokecube.command.poketm true then did /poketm rest, and recieved a rest TM, so the permissions are working as intended.

smmmadden commented 6 years ago

thanks for testing. I should have been more specific. The problem with the permissions is I've assigned users to "default" group. Added all the permissions for typical users there. Each user should not need the same perm node but should be getting perms from those defined in the default group. So while the permissions can be added to the group or user, in the game the permissions are not working - even for my own id which I've set to "admins" group with parent of "default". I set the same perms as thut.perms but the behavior is not the same. I experienced similar behavior using PEX as well which led me to believe that perhaps there is no permission check for LuckPerms or PEX to use it? Thanks!

Thutmose commented 6 years ago

thutperms uses a different permissions system from the other two (class based instead of command based), the perms will be different for LP or PEX than for thutperms

So long as the per-user settings for LP work (as did in my testing) then they should work in any group, try testing with vanilla command permissions first? maybe you are doing something wrongly in the setup?