Thutmose / Pokecube

Primary Development has moved to: https://github.com/Pokecube-Development
https://github.com/Pokecube-Development
19 stars 7 forks source link

Wearable will disappear when player dies #317

Closed Philosyang closed 6 years ago

Philosyang commented 6 years ago

Issue Description:

You lose all of your wearables in your pokecube inventory if you had put them in your pokecube inventory and you die.

What happens:

You lose all of your wearables, they disappear.

What you expected to happen:

You don't lose any of them.

Steps to reproduce:

  1. Put a bag, a watch or anything that can be fitted into the pokecube inventory slots. image

  2. Kill yourself with any method.

  3. Your wearables will not exist neither in the pokecube inventory slots nor the PC.


Affected Versions:

Thutmose commented 6 years ago

I cannot replicate this, they go to my PC when I die

Thutmose commented 6 years ago

is there anything showing up in logs when this happens for you? also can you send a zip of your config folder, maybe it is something in there that is different from my testing environment

Philosyang commented 6 years ago

I found the problem.

I made /gamerule keepInventory true for my server (this also applies to singleplayer). When KeepInventory is true, you kill yourself, then your wearables that were in pokecube inventory slots will no longer exist neither in the pokecube inventory slots nor the PC.

Thutmose commented 6 years ago

ahh, I see, that gamerule being true must prevent the drops from occuring, the wearables are not saved over when the player dies, so if nothing drops, they disappear

Thutmose commented 6 years ago

I will look into fixes for this, I suepct I will need to do something differently if that gamerule is on...

Philosyang commented 6 years ago

Awesome dev!

Thutmose commented 6 years ago

this should be fixed in Pokecube AIO: 1.12.2-1.6.18, please test it whenever it is available, and close this issue if it is fixed.

Philosyang commented 6 years ago

Unfortunately, it didn't work for me. /gamerule KeepInventory true, /kill, wearables still disappear, and nothing in my PC.

Thutmose commented 6 years ago

image

these stay in my inventory when I run /kill with this modset: image

Philosyang commented 6 years ago

My fault, I added the 1.6.18 into my mods folder and deleted 1.6.18 instead of 1.6.16

Problem solved.