search

Thutmose / Thut

new repository for my mods
17 stars 11 forks source link

Crash Report when installed alongside Astral Sourcery #78

Closed GreyMamoN closed 6 years ago

GreyMamoN commented 6 years ago

## Versions above 5.11.10 give an error Forge 1.12.2 - 14.23.1.2556 The server is crashing I apologize for the bad English ...

Caused by: java.lang.ClassCastException: thut.api.terrain.CapabilityTerrain$DefaultProvider cannot be cast to hellfirepvp.astralsorcery.common.base.FluidRarityRegistry$ChunkFluidEntry at hellfirepvp.astralsorcery.common.base.FluidRarityRegistry.onChLoad(FluidRarityRegistry.java:122) ~[FluidRarityRegistry.class:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_620_FluidRarityRegistry_onChLoad_Load.invoke(.dynamic) ~[?:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?] at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:652) ~[EventBus.class:?] ... 15 more

Thutmose commented 6 years ago

That crash is caused by astralsourcery

Thutmose commented 6 years ago

Hmm, though looking at how they do their checks, it shouldn't be occurring

Daihok41 commented 6 years ago

I am having same issue if i revert back to previous thut core 5.11.10 issue does not happen. It only started with the last couple thut core updates. Happens with 5.12.0 and 5.12.1

Thutmose commented 6 years ago

ya, the latest thutcores (5.12.+) swapped over to using capabilities for some internal stuff, and somehow Astral Sourcery is trying to cast the thutcore chunk capabilities to its own type.

crimso commented 6 years ago

Hello

I have the same problem when I want to load my SSP world, so should I report it to astral sourcery ?

Thank you

Thutmose commented 6 years ago

yes, also report it there, then link this issue to the one you post there, hopefully this evening I will have time to try to look into what is going on, at first glance I don't see anything that either of the two mods are doing wrongly

crimso commented 6 years ago

ok ok, the interesting thing is that If I use the older version from astral sorcery then is working ok so the problem is maybe on his side.

Thutmose commented 6 years ago

ya, I didn't have time for a full check, but when I glanced at his code, and looked over mine, both seem to be done properly, so not entirely sure why the crash is occuring, but it is definitely an interaction of some kind going badly between the two mods

HellFirePvP commented 6 years ago

I do my stuff properly aswell.

https://github.com/HellFirePvP/AstralSorcery/blob/master/src/main/java/hellfirepvp/astralsorcery/common/base/FluidRarityRegistry.java#L146 https://github.com/HellFirePvP/AstralSorcery/blob/master/src/main/java/hellfirepvp/astralsorcery/common/base/FluidRarityRegistry.java#L250

So where is this issue at? Both seem to properly set the capability at different registry names and check for their Capability-Instance.

Thutmose commented 6 years ago

ya, and mine are here: https://github.com/Thutmose/Thut/blob/1.12.x/ThutCore/src/main/java/thut/api/terrain/CapabilityTerrain.java#L86-L98 https://github.com/Thutmose/Thut/blob/1.12.x/ThutCore/src/main/java/thut/api/terrain/TerrainManager.java#L33-L48 https://github.com/Thutmose/Thut/blob/1.12.x/ThutCore/src/main/java/thut/core/common/ThutCore.java#L195

so I don't see anything that either of us are doing wrongly, probably something on forge's end?

Thutmose commented 6 years ago

This has now been fixed in thutcore 5.12.3, thanks to @HellFirePvP for finding the error on my end :D