Thutmose / Thut

new repository for my mods
17 stars 11 forks source link

Crash when loading with both Baubles and Advanced Rocketry? #82

Closed Keetarin closed 6 years ago

Keetarin commented 6 years ago

When I installed Baubles and Advanced Rocketry together with Thut Wearables, Thut Wearables tries to convert advanced rocketry's Space Suit armor pieces into baubles despite them not being such thus throwing a crash. Even after turning off Baubles compatibility, Thut Wearables still tried to convert the space suit into a bauble. I tested the offending mods in a pack with just them and all required API's but was unable to replicate it in the test pack... don't know why Thut Wearables is doing this. Offending Mods: Baubles, Advanced Rocketry, Thut Wearables Heres the Crash Log from the non-test pack (current build of a modpack i'm making): crash-2017-12-20_09.06.40-client.txt Edit: It's happened again, after it had just stopped happening, it seems they don't want to play nice.... crash-2017-12-20_09.35.22-client.txt

Thutmose commented 6 years ago

This is odd, shouldn't happen, I will look into what is going wrong here...

Thutmose commented 6 years ago

This definitely does not occur with just the offending mods: image

Some other mod is badly returning some value for its capability

Keetarin commented 6 years ago

Thanks for looking in to it, I need Thut Wearables due to this pack being centered on Tech mods and Pokecube.

Keetarin commented 6 years ago

I'll send the pack to you for testing, most of the mods I'm planning to use are currently disabled due to the pack being in a heavy testing phase. Edit: From what i've seen on my end, the bug appears to be intermittent, though it does seem to be showing up often to me.

Thutmose commented 6 years ago

this is where the crash is occuring: https://github.com/Thutmose/ThutWearables/blob/1.12/src/main/java/thut/wearables/compat/baubles/Compat.java#L53-L57 specifically on line 56, the crash means some mod has returned true for having the wearables capability, but is then returning the item for the getCapability call...

Keetarin commented 6 years ago

Huh... Okay, the only mods I know of that I know of in my pack that has wearables capability with a cap in it would be the pokecube mods, but that can't be it.... gimme a mo while I test the bauble side of things (assuming the bug doesn't hide itself from me again :( )

Thutmose commented 6 years ago

it could be an issue with any itemstack capability, I had a bug in one of my mods related to chunk capabilities with a typo in the hasCapability check, so another mod could have done similar

Keetarin commented 6 years ago

Ah! nearly forgot to give the pack to you! Pokecube Survival (Name Pending)-1.0.zip Edit: It's easier to find a bug when both people have a copy of the proverbial map.

Thutmose commented 6 years ago

in the mean time while that is downloading, I will check the pokecube ones to see if they are the issue

Keetarin commented 6 years ago

Thanks for helping me look into this, this bug is a pain in the ***.

Thutmose commented 6 years ago

not caused directly by any of the pokecube mods: image image

Keetarin commented 6 years ago

Okay, this is strange... I've sent a copy of the pack to you earlier on, so It should contain a list (mainly in the crash logs) of the mods I was testing at the time as well as the means to get the mods quickly. I honestly don't know of any of the mods aside from pokecube having direct wearables compatibility, after all, I've used baubles for most of my personal packs. Edit: I just woke up about an hour ago, so my brain is going a bit slow...

Thutmose commented 6 years ago

the pack you sent as is, doesn't seem to have this crash, one thing I did notice was the inclusion of Pokecube Alternative, a word of warning, that mod is not balanced for survival use, it is intended for adventure mode

Keetarin commented 6 years ago

Really? I didn't know that (about pokecube alternative), I'll remove that for now since honestly I don't want build an adventure pack. Still, where could that bug be hiding???

Thutmose commented 6 years ago

Ya, a main balance point in pokecube is that the pokemobs use up inventory slots, alternative makes them have their own slots, so that balance is gone.

I am checking with all of the mods enabled

Thutmose commented 6 years ago

heh never mind testing with all of them enabled, at least one of them has a major issue:

https://gist.github.com/Thutmose/803cc07f1a6552618ef6c3e71cea6aea

no indication of which from the report either...

Keetarin commented 6 years ago

@ Previous Comment: Thanks, honestly, while I'm good at putting together a stable pack, trying to find a bug that doesn't show where it's from is kinda beyond me... sigh looks like I'll have to disable baubles for now on my end. @ Current Comment: That looks similar to the error I got when I tried to have Immersive Engineering in the pack??? I know for a fact that I had removed that. Do you know which mod you enabled before that error got thrown, or did you simply enable them all at the same time?

Thutmose commented 6 years ago

I just enabled all of them at once, I use IE in my poke-tech survival modpack, so it shouldn't be related to that, let me test it with baubles as well

Keetarin commented 6 years ago

Huh? Is that error related to multiblocks by chance? Edit: Multiblock Structures...

Thutmose commented 6 years ago

IE + Baubles + Wearables + Pokecube set seems to work fine:

image

Keetarin commented 6 years ago

Okay, this is getting weird. The error you got, do you know what it specifically refers to in terms of type of thing in-game: multiblocks, items, or somesuch?

Thutmose commented 6 years ago

No idea, that is some internal forge thing for loading in the model jsons

Keetarin commented 6 years ago

Curses, sigh, still better than nothing I suppose.

Thutmose commented 6 years ago

you have 20 coremods as well, so it could be caused by one of them messing with the wrong thing

Keetarin commented 6 years ago

True, but at the moment, only the mods specified in the crash log are enabled for testing at this stage, so really it could only be one of those if it is.

Thutmose commented 6 years ago

I would suggest going through them and seeing if you can find out which one is causing the crash, it should happen every time you load the game with a space suit in your inventory if the offending mod is active

Keetarin commented 6 years ago

Sure. Though that would take time... and I do believe I've mentioned above that the bug sometimes does not show. Still at least I now know that the it's not any of the three mods that were showing themselves as offenders.

Keetarin commented 6 years ago

I'll get back to you in about an hour after testing what's currently enabled. Edit: I hate being tired in the morning, my brain goes so slowly :( so many edits

Thutmose commented 6 years ago

good luck with the testing

Keetarin commented 6 years ago

Looks like I may have found the culprit, it appears to be IC2 from the initial tests, I'll remove IC2 and all that require it as a test later. For now, lunch time.

Keetarin commented 6 years ago

I tested it and it indeed was IC2, also just to confirm whether or not Immersive Engineering was a problem I put it in a test pack by itself.... I'll be sending the crash log to the creator of the mod, but I thought you would like to see it since it might effect your pack. crash-2017-12-20_13.03.15-client.txt Edit: Forgot to mention which version of IE & forge smacks head IE 0.12 - 75 Forge-14.23.1.2578

Thutmose commented 6 years ago

Closing this issue then, hopefully they get it fixed