search

Thysbelon / gba-mus-ripper

A fork of a fork of a forked version of GBA Mus Ripper.
https://thysbelon.github.io/Blog/2024-9-24/My-Attempts-to-Improve-GBA-Music-Romhacking-and-SiIva-Style-Ripping
MIT License
2 stars 0 forks source link

Percussion issues #2

Closed Bonboon229 closed 1 week ago

Bonboon229 commented 1 week ago

Drumkits sound far higher pitched then they are suppossed to be in many midi rips

Thysbelon commented 1 week ago

Thank you for reporting this.

I suspect this issue is connected to when I replaced sappy_detector with mp2ktool.
When I was making that edit, I noticed that gba_mus_ripper relies on the sound engine address that sappy_detector gives to get the sample rate of the sound engine.
sample rate controls the speed at which a sample is played. Different GBA games use different sample rates. Playing a sound at a higher sample rate than intended will raise the pitch of the sound.
This also means that the original gba_mus_ripper likely has a bug where, if the address to the sound table is given on the command line, it won't run sappy_detector and thus won't get the engine's sample rate.

In the next release, I'll implement a way for gba_mus_ripper to get the sample rate of any game that uses the MP2K sound engine.

Bonboon229 commented 1 week ago

Brilliant!

Bonboon229 commented 1 week ago

Also should add that dragging a rom onto the main exe no longer works

Thysbelon commented 1 week ago

I believe this should be fixed by the latest release v1.3.2.

gba_mus_ripper can now once again get the sample rate and volume of any GBA game that the original gba_mus_ripper was capable of getting the sample rate and volume from.

Getting the sample rate and volume of any MP2K game will be more difficult than I thought, and may not even be possible, so this v1.3.2 release doesn't do that.

Thank you.