search

TiZ-HugLife / xfce4-dockbarx-plugin

A plugin that embeds DockbarX into Xfce4-panel
MIT License
70 stars 14 forks source link

Figure out bg color of none style somehow #18

Closed TiZ-HugLife closed 9 years ago

TiZ-HugLife commented 9 years ago

The current method of forcing users of the none style to define their color with the solid color style is not friendly at all. It's actually worse now because if you don't read the readme, the plug will crash and you'll have no idea why.

We need to do gtk detection somehow. Whether we have to do that in the plug or in the socket, I don't presently know. If I can set the widget class to match xfce4-panel in the plug, then sweet, we can just do it in the plug. Otherwise, we'll have to have the socket do it and tell the plug somehow.

If we have to use the socket to do it, we could have the socket set the xfconf property, maybe.

One problem will be detecting GTK theme changes. There's probably not a way to work around this. There is a signal to let us do it or there isn't.

TiZ-HugLife commented 9 years ago

c52684835ca0e2cd3d5632afd8a81b8917eac070 should fix this at the basic level.