search

TiZ-HugLife / xfce4-dockbarx-plugin

A plugin that embeds DockbarX into Xfce4-panel
MIT License
70 stars 14 forks source link

Blend with panel is broken in 0.5 #23

Closed hashn0n closed 8 years ago

hashn0n commented 8 years ago

Starting with commit 9f6abeda7cc673a3a1cfe9c4167023f84fee8a35, if "Blend with panel" is active, DockBarX isn't showing on xfce4-panel, I can get in to settings and switch to "Solid color" and back "Blend with panel" and it's working again only up to next start/restart of xfce4-panel. If set to "Solid color" it works all the time. Log is attached. xfce4-panel.zip

TiZ-HugLife commented 8 years ago

Hey there, sorry it's taken so long to reply to this. My day job has started going super hard in the paint so I haven't had time until now to look at this.

Looks like this is the relevant stack trace:

Traceback (most recent call last):
  File "/usr/share/xfce4/panel/plugins/xfce4-dockbarx-plug", line 151, in image_pattern
    tx = self.offset if self.orient in ("up", "down") else 0
AttributeError: 'DockBarXFCEPlug' object has no attribute 'orient'
Failed to load image.

I'll try to see why this particular attribute isn't being set the way it should be.

hashn0n commented 8 years ago

Not problem, it's not the "game breaker" since it still works, just not so pretty. :)

TiZ-HugLife commented 8 years ago

Yeah, but it's supposed to be pretty. So let's get this nipped in the bud. I think I've figured it out; config_bg gets called before the orientation gets initialized. I have no idea how I made such a newbie mistake. I'm going to make sure this works then I'll commit and you can try it out.

TiZ-HugLife commented 8 years ago

Bluh, silly commit auto-closing this. It was an attempt, haha! Go ahead and build this and try it out.

hashn0n commented 8 years ago

Ok, it look's as pretty as it's supposed to be now, rebooted to make sure! Should I close this bug, not really used to all this bug-traking stuff.

TiZ-HugLife commented 8 years ago

You can close any issue on github whenever you're satisfied with its resolution (or lack thereof in some cases). Since you've clearly indicated you're happy with the fix, I'll go ahead and do it for you. Thank you! ^.^