search

TiZ-HugLife / xfce4-dockbarx-plugin

A plugin that embeds DockbarX into Xfce4-panel
MIT License
70 stars 14 forks source link

0.3: changing theme makes the xfce dockbarx plugin disappear #9

Closed hotice closed 10 years ago

hotice commented 10 years ago

With version 0.3, the plugin disappears from the panel when changing the DockBarX theme and then clicking the refresh button (it works after a xfce panel restart).

TiZ-HugLife commented 10 years ago

Yup, I can reproduce this exactly. That's a bummer, to say the least. A quick and filthy way to get it to come back is pkill -f dockbarx-plug. I abuse that command way more than I should. I'll start researching this.

hotice commented 10 years ago

Thanks!

TiZ-HugLife commented 10 years ago

Okay, so the DBX log has this to say:

INFO    | 2014-06-17 12:09:32,405   | DockbarX 0.91
INFO    | 2014-06-17 12:09:32,405   | DockbarX init
INFO    | 2014-06-17 12:09:32,461   | DockbarX reload
ERROR   | 2014-06-17 12:11:19,058   | Traceback (most recent call last):
ERROR   | 2014-06-17 12:11:19,059   |   File "/usr/lib/python2.7/site-packages/dockbarx/windowbutton.py", line 385, in __update_label
ERROR   | 2014-06-17 12:11:19,059   |     text = escape(str(window.wnck.get_name()))
ERROR   | 2014-06-17 12:11:19,059   | AttributeError: Window instance has no attribute 'wnck'
ERROR   | 2014-06-17 12:11:19,059   | Traceback (most recent call last):
ERROR   | 2014-06-17 12:11:19,059   |   File "/usr/lib/python2.7/site-packages/dockbarx/windowbutton.py", line 385, in __update_label
ERROR   | 2014-06-17 12:11:19,060   |     text = escape(str(window.wnck.get_name()))
ERROR   | 2014-06-17 12:11:19,060   | AttributeError: Window instance has no attribute 'wnck'
INFO    | 2014-06-17 12:11:52,178   | Executing: exo-open --launch TerminalEmulator
INFO    | 2014-06-17 12:13:23,230   | DockbarX reload

I'm going to take a guess that this one's an upstream issue. @M7S, want me to make an issue at your launchpad?

TiZ-HugLife commented 10 years ago

I spoke too soon. I just tested it in DockX, and DockX doesn't act up when the theme is refreshed. So it's my cross to bear after all. @M7S, any insights on this?

M7S commented 10 years ago

Those error messages are not related to the bug, I guess? They happen more than a minute before the reload, the first DockbarX reload is sent on upstart automatically. The bug might very well be on DockbarX side since DockX takes care of reloads itself while xfce plugin lets DockbarX deal with it on its own. I'll look into it. You can assign this bug to me (if it's possible to assign bugs to non members or whatever it's called) if you want and I'll make a pull request if something is needed to be changed in the plug.

TiZ-HugLife commented 10 years ago

Fixed in 0.3.1 and DBX 0.91.2.