search

TiagoCavalcante / r3f-native-orbitcontrols

OrbitControls for React Three Fiber in React Native
MIT License
72 stars 10 forks source link

Feature Request: 'maxDistance', 'minDistance' Props Support and 'setLookAt'/'dollyTo' Methods #20

Closed yaroslavnikiforov closed 1 year ago

yaroslavnikiforov commented 1 year ago

I would like to express my appreciation for the excellent library and its functionalities.

However, I have identified a need for additional features that would enhance its capabilities even further. Specifically, support for the 'maxDistance' and 'minDistance' props, as well as the inclusion of methods like 'setLookAt' and 'dollyTo', similar to what is available in the 'camera-controls' package. These additional features would greatly enhance the flexibility and functionality of the library.

TiagoCavalcante commented 1 year ago

Hi @yaroslavnikiforov

There is already minZoom and maxZoom which are equivalent to minDistance and maxDistance.

setLookAt and dollyTo would be really a copy-and-paste from the equivalent functions in the Camera object, so I believe it doesn't make sense to add them.

Your thoughts?

TiagoCavalcante commented 1 year ago

I'm closing this now. Please re-open it in case my last comment didn't solve your issue.