Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process.
The problem is caused by an issue with error handling in the @octokit/webhooks library because the error can be undefined in some cases.
Credit goes to @pb82 (for the early analysis) and @rh-tguittet (for discovery).
Patches
Maintenance releases for the Error being thrown by the verify method in octokit/webhooks.js
This PR contains the following updates:
11.3.0->12.3.3GitHub Vulnerability Alerts
CVE-2023-50728
Impact
Versions v9.26.0, v10.9.x), v11.1.x, v12.0.x all contained the code that would throw the error.
Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process.
The problem is caused by an issue with error handling in the @octokit/webhooks library because the error can be undefined in some cases.
Credit goes to @pb82 (for the early analysis) and @rh-tguittet (for discovery).
Patches
Maintenance releases for the Error being thrown by the verify method in octokit/webhooks.js
Maintenance release for the reference for octokit/webhooks.js in app.js
Maintenance release for the reference for octokit/webhooks.js in octokit.js
Maintenance release for the reference for octokit/webhooks.js in Protobot
Workarounds
It is recommend that all users upgrade to the latest version of octokit/webhooks.js or use one of the updated back ported versions.
Release Notes
probot/probot (probot)
### [`v12.3.3`](https://togithub.com/probot/probot/releases/tag/v12.3.3) [Compare Source](https://togithub.com/probot/probot/compare/v12.3.2...v12.3.3) ##### Bug Fixes - **deps:** `@octokit/webhooks` security update ([#1911](https://togithub.com/probot/probot/issues/1911)) ([02d81f8](https://togithub.com/probot/probot/commit/02d81f886cf8f4b7725523a1c4958127015dcfb0)) ### [`v12.3.2`](https://togithub.com/probot/probot/releases/tag/v12.3.2) [Compare Source](https://togithub.com/probot/probot/compare/v12.3.1...v12.3.2) ##### Bug Fixes - Fix async main function type ([#1672](https://togithub.com/probot/probot/issues/1672)) ([fc6886d](https://togithub.com/probot/probot/commit/fc6886d3b3c4308a78a896ccde1c99648db4953a)) ### [`v12.3.1`](https://togithub.com/probot/probot/releases/tag/v12.3.1) [Compare Source](https://togithub.com/probot/probot/compare/v12.3.0...v12.3.1) ##### Bug Fixes - **typescript:** simplify ProbotWebhooks object ([#1833](https://togithub.com/probot/probot/issues/1833)) ([7b09369](https://togithub.com/probot/probot/commit/7b09369f4b417f9fc60ca0bcea5678b5169a3421)) ### [`v12.3.0`](https://togithub.com/probot/probot/releases/tag/v12.3.0) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.9...v12.3.0) ##### Features - **server:** add logging options ([#1645](https://togithub.com/probot/probot/issues/1645)) ([6c5840d](https://togithub.com/probot/probot/commit/6c5840d2dfccc07031f3ad6944513e75ef133f5b)) ### [`v12.2.9`](https://togithub.com/probot/probot/releases/tag/v12.2.9) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.8...v12.2.9) ##### Bug Fixes - **typescript:** add missing import ([#1783](https://togithub.com/probot/probot/issues/1783)) ([229a01c](https://togithub.com/probot/probot/commit/229a01c7bf387696ee02574811bd61b21f33a2ab)) ### [`v12.2.8`](https://togithub.com/probot/probot/releases/tag/v12.2.8) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.7...v12.2.8) ##### Bug Fixes - Make `probot receive` support complex Probot apps ([#1714](https://togithub.com/probot/probot/issues/1714)) ([eff5553](https://togithub.com/probot/probot/commit/eff55532534b980385a21835230d8fa7251463ac)) ### [`v12.2.7`](https://togithub.com/probot/probot/releases/tag/v12.2.7) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.6...v12.2.7) ##### Bug Fixes - **receive:** `--base-url` option and `GHE_HOST` ([#1719](https://togithub.com/probot/probot/issues/1719)) ([68c9b91](https://togithub.com/probot/probot/commit/68c9b91b89fa8ac6dd4bb3f6a8a3d7272a211619)) ### [`v12.2.6`](https://togithub.com/probot/probot/releases/tag/v12.2.6) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.5...v12.2.6) ##### Bug Fixes - **deps:** upgrade octokit/types to v7.1.1 ([#1724](https://togithub.com/probot/probot/issues/1724)) ([be45120](https://togithub.com/probot/probot/commit/be45120fab284d5d2596e24ace010d06cd740648)) ### [`v12.2.5`](https://togithub.com/probot/probot/releases/tag/v12.2.5) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.4...v12.2.5) ##### Bug Fixes - remove update-notifier ([#1706](https://togithub.com/probot/probot/issues/1706)) ([05297fb](https://togithub.com/probot/probot/commit/05297fbd500c40a82ac648493ee3064c0af2bcb5)), closes [/github.com/probot/probot/issues/1102#issuecomment-570598406](https://togithub.com//github.com/probot/probot/issues/1102/issues/issuecomment-570598406) ### [`v12.2.4`](https://togithub.com/probot/probot/releases/tag/v12.2.4) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.3...v12.2.4) ##### Bug Fixes - logging of first octokit instance is not set ([#1676](https://togithub.com/probot/probot/issues/1676)) - thanks [@kammerjaeger](https://togithub.com/kammerjaeger) [@markjm](https://togithub.com/markjm) ([646b6a9](https://togithub.com/probot/probot/commit/646b6a9276f1873f82d938020849193dbd2da89d)) ### [`v12.2.3`](https://togithub.com/probot/probot/releases/tag/v12.2.3) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.2...v12.2.3) ##### Bug Fixes - **deps:** bump eventsource from 1.1.0 to 2.0.2 ([7fd06d6](https://togithub.com/probot/probot/commit/7fd06d697503b45a56742aec3f4eb7e8157a7c7f)) ### [`v12.2.2`](https://togithub.com/probot/probot/releases/tag/v12.2.2) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.1...v12.2.2) ##### Bug Fixes - Replaced hbs with express-handlebars ([#1659](https://togithub.com/probot/probot/issues/1659)) ([420f886](https://togithub.com/probot/probot/commit/420f88612dc517607bb240de031a242a8129e820)) ### [`v12.2.1`](https://togithub.com/probot/probot/releases/tag/v12.2.1) [Compare Source](https://togithub.com/probot/probot/compare/v12.2.0...v12.2.1) ##### Bug Fixes - **security:** bump minimal version of `hbs` ([#1638](https://togithub.com/probot/probot/issues/1638)) ([dd9f5ae](https://togithub.com/probot/probot/commit/dd9f5ae98e535fb434296cb8cc6e6b24f663430b)) ### [`v12.2.0`](https://togithub.com/probot/probot/releases/tag/v12.2.0) [Compare Source](https://togithub.com/probot/probot/compare/v12.1.4...v12.2.0) ##### Features - customize account name for manifest creation flow using `GH_ORG` environment variable ([#1606](https://togithub.com/probot/probot/issues/1606)) ([992b480](https://togithub.com/probot/probot/commit/992b4800738b18a184f31eecf0287d9be6a63b47)) ### [`v12.1.4`](https://togithub.com/probot/probot/releases/tag/v12.1.4) [Compare Source](https://togithub.com/probot/probot/compare/v12.1.3...v12.1.4) ##### Bug Fixes - **types:** export `ApplicationFunction` ([#1631](https://togithub.com/probot/probot/issues/1631)) ([073f087](https://togithub.com/probot/probot/commit/073f08793d47f8b73a9435a44c258d6d281fb040)) ### [`v12.1.3`](https://togithub.com/probot/probot/releases/tag/v12.1.3) [Compare Source](https://togithub.com/probot/probot/compare/v12.1.2...v12.1.3) ##### Bug Fixes - log json in production ([#1598](https://togithub.com/probot/probot/issues/1598)) ([bb068d9](https://togithub.com/probot/probot/commit/bb068d9ae2407df8a07ffa64dc7d7fb8f01f097a)) ### [`v12.1.2`](https://togithub.com/probot/probot/releases/tag/v12.1.2) [Compare Source](https://togithub.com/probot/probot/compare/v12.1.1...v12.1.2) ##### Bug Fixes - **typescript:** add types for `context.{repo,issue,pullRequest}` ([#1622](https://togithub.com/probot/probot/issues/1622)) ([638a3b2](https://togithub.com/probot/probot/commit/638a3b225593889d2f57c48061aa0cb2f9eb61d5)) ### [`v12.1.1`](https://togithub.com/probot/probot/releases/tag/v12.1.1) [Compare Source](https://togithub.com/probot/probot/compare/v12.1.0...v12.1.1) ##### Bug Fixes - update ioredis to non-vulnerable version ([#1589](https://togithub.com/probot/probot/issues/1589)) ([f02c549](https://togithub.com/probot/probot/commit/f02c5498fdc9ef76df3f1250fec720403489eb34)) ### [`v12.1.0`](https://togithub.com/probot/probot/releases/tag/v12.1.0) [Compare Source](https://togithub.com/probot/probot/compare/v12.0.0...v12.1.0) ##### Features - **website:** 11ty 🚀 ([#1516](https://togithub.com/probot/probot/issues/1516)) ([7a43e9e](https://togithub.com/probot/probot/commit/7a43e9e5d41cbe71ca416b3780c93a6c303c739a)) ### [`v12.0.0`](https://togithub.com/probot/probot/releases/tag/v12.0.0) [Compare Source](https://togithub.com/probot/probot/compare/v11.4.1...v12.0.0) ##### Features - update `@octokit/webhooks` to v9 ([#1559](https://togithub.com/probot/probot/issues/1559)) ([4b3ae0e](https://togithub.com/probot/probot/commit/4b3ae0eee59c7ecf0348299b9c13fe87e516c740)) ##### BREAKING CHANGES - remove '\*' event - app.webhooks.middleware has been removed in `@octokit/webhooks` v9 - removes the `webhookPath` option on `new Probot({})` for the webhooks middleware Co-authored-by: wolfy1339Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.