search

TianhongDai / reinforcement-learning-algorithms

This repository contains most of pytorch implementation based classic deep reinforcement learning algorithms, including - DQN, DDQN, Dueling Network, DDPG, SAC, A2C, PPO, TRPO. (More algorithms are still in progress)
661 stars 106 forks source link

Add prioritized experience replay #4

Open JasAva opened 5 years ago

JasAva commented 5 years ago

Thanks for the excellent implementations of multiple classic RL agents, I have tried some of them, worked very well. Just curious, do you plan to add the prioritized experience replay to the DQN? I have tried to embed the openai baseline PER files (https://github.com/openai/baselines/blob/master/baselines/deepq/replay_buffer.py) to the current DQN, should be a really easy job, sadly it doesn't work very well, seems no obvious improvements against the vanilla DQN. If you have any insights on this or have you tried some similar implementation, please let me know, really appreciate it.

TianhongDai commented 5 years ago

@JaceZA Hi, no problem - I will try to work on the prioritized experience replay in the next week. Before that maybe you can check this implementation from: https://github.com/Kaixhin/Rainbow

JasAva commented 5 years ago

Thanks so much, I have come across the Rainbow implementation and will continue to figure out where I did wrong. (Sorry for the accident close and reopen), keep me posted on your implementation. Thanks again.

TianhongDai commented 5 years ago

@JaceZA Don't worry, no problem.

TianhongDai commented 5 years ago

@JasAva Sorry for the delay of the update, I need to focus on the deadline in the next following weeks. Then i will try to make a huge update to the repository. Firstly, i will write the pre-processing functions. In this case, we don't need to install openai baselines for their pre-processing functions. Secondly, update the PER for DQN algorithms. Sorry for I don't update the code in these period😣.

JasAva commented 5 years ago

@TianhongDai No problem, thanks for letting me know, good luck with the deadline.