search

TianyiShi2001 / audiotags

Unified IO for different types of audio metadata
https://tianyishi2001.github.io/audiotags
MIT License
41 stars 29 forks source link

Support for comment tag #31

Closed a1049145827 closed 6 months ago

pinkforest commented 6 months ago

This is very specific to Id3 I think ? Is there equivalent for other formats

I think this is in id3::frame::Comment and there is also id3::frame::Lyrics similar to Picture we already have.

@Serial-ATA I know this is probably out of scope to abstract at audiotags level ?

Would it be worthwhile exposing this low level information opportunistically ?

Serial-ATA commented 6 months ago

This is very specific to Id3 I think ? Is there equivalent for other formats

Comments exist in all 3 of the tag formats supported. The thing is, ID3v2 provides way more options for comments, opposed to MP4 ilst and Vorbis Comments which are just simple strings.

It'd probably be more trouble than it's worth to add these complex items to a crate this high-level. If you need to support more items outside of the basic title, album, artist, etc. then I'd recommend just using lofty.

pinkforest commented 6 months ago

Ok cool - sounds like #44 applies here and better to direct to lofty