search

TianyuCheng / Rlanet-Renderer

A GPU-based planet renderer from scratch
11 stars 3 forks source link

Clean up GLSL #8

Closed xinyazhang closed 9 years ago

xinyazhang commented 9 years ago
  1. Ensure no DOS style line breaks.
  2. Ensure no texture2D in all GLSL code. OS X does not support this.
tycheng commented 9 years ago

Last time when I pulled, I got vertex shader with MSDOS style line breaks. I did not delete those because I though that was okay for compilation.

tycheng commented 9 years ago

What does OS X support for texture?

xinyazhang commented 9 years ago

OSX only supports overloaded texture in GLSL, instead of texture1/2/3D Linux is more flexible, although I believe it's only because they reused old compiler to parse GLSL.

xinyazhang commented 9 years ago

Check this highlighter https://github.com/beyondmarc/glsl.vim. It marks legacy keywords in a different color.

tycheng commented 9 years ago

Okay, thank.