search

TiberiuC39 / SharpOverlay

SharpOverlay is a set of iRacing overlays built on .NET & WPF. It aims to provide free & open-source versions of useful widgets.
MIT License
24 stars 3 forks source link

Color pickers not initialized with current color #2

Closed rouyng closed 3 months ago

rouyng commented 3 months ago

Current behavior: When using the color pickers to change bar and input line colors, all pickers default to #FFFFFF. Expected behavior: Each color picker should default to current color in use for the selected bar/input item.

This makes small adjustments to currently chosen colors more difficult and imprecise, as you have to manually navigate through the color picker to the same or similar color. Additionally, the eyedropper tool within the color picker seems to be nonfunctional so you can't use it to pick the item's current color.

Thanks for this software. It's a great thing for the iRacing community to have open source implementations of common overlays.

TiberiuC39 commented 3 months ago

Hi!

Thank you for such a well-written bug report :)

Fix is out in v0.2.1

The problem was that I wasn't setting the color picker's selected brush to the color already set. I decided to take this opportunity to replace that color picker altogether with the much-nicer (atleast in my opinion) one from PixiEditor.

This is how it looks and works now:

https://github.com/user-attachments/assets/14884001-232f-415b-961b-87b6ffaf8622

rouyng commented 3 months ago

Just updated, works great now. I agree this new picker is nicer. Thank you!