TibiaData / tibiadata-api-go

TibiaData API written in Golang and deployed in container (version v3 and above).
https://api.tibiadata.com
MIT License
81 stars 28 forks source link

Various `/news/id/*` responses have empty `content` and `content_html` #290

Closed mathiasbynens closed 10 months ago

mathiasbynens commented 10 months ago

For example, https://api.tibiadata.com/v3/news/id/504 returns the following (after pretty-printing):

{
  "news": {
    "id": 504,
    "date": "2007-04-27",
    "category": "community",
    "type": "ticker",
    "url": "https://www.tibia.com/news/?subtopic=newsarchive&id=504",
    "content": "",
    "content_html": ""
  },
  "information": {
    "api_version": 3,
    "timestamp": "2023-11-09T12:10:50Z"
  }
}

However, the news ticker at https://www.tibia.com/news/?subtopic=newsarchive&id=504 does have content:

A new feedback form has been released today. Help us to find out which websites and magazines are popular in your country by filling out the new questionnaire. In our current poll we are curious about your occupation.

Here’s some example affected IDs (these might all share the same root cause):

444
445
447
448
451
453
454
455
456
458
459
460
463
464
465
466
467
469
470
471
474
475
476
477
478
481
482
483
484
485
486
487
489
490
491
492
493
494
497
498
500
501
503
504
506
507
509
510
512
514
516
517
518
520
522
523
524
527
529
530
532
533
535
537
539
540
541
544
545
546
548
549
550
552
554
556
557
559
560
563
564
567
568
569
570
572
574
575
576
577
578
579
580
581
582
588
589
590
591
592
594
595
596
599
600
603
604
608
609
610
612
613
615
616
617
618
621
622
625
626
627
628
629
631
635
636
637
639
640
641
642
644
645
648
649
651
652
653
654
655
656
657
658
660
661
662
664
665
666
669
670
675
676
677
678
679
681
682
683
684
686
687
688
689
690
692
693
694
695
696
697
701
702
703
704
705
706
709
710
711
712
713
715
717
718
720
721
722
723
725
726
727
729
730
731
733
735
736
737
739
740
742
743
744
745
746
749
751
752
757
758
759
760
763
764
765
768
769
770
771
773
774
775
776
778
779
780
781
782
783
786
787
788
789
790
792
793
794
795
796
797
798
800
801
803
806
807
808
809
812
813
814
816
817
818
820
821
823
825
826
827
829
831
832
833
834
837
838
839
841
842
843
846
847
848
849
851
852
853
854
856
857
858
862
866
867
868
871
875
877
879
880
881
882
885
886
889
891
892
893
895
896
898
899
900
902
903
904
905
907
908
911
912
913
914
915
917
919
920
922
923
924
925
926
927
929
930
931
932
933
935
936
938
939
940
941
942
943
947
949
950
952
953
954
956
958
959
961
962
963
964
966
967
968
970
972
973
974
975
976
977
979
981
982
983
985
986
987
989
990
991
992
993
997
999
1000
1001
1004
1005
1006
1007
1010
1011
1012
1013
1015
1016
1018
1019
1020
1022
1024
1025
1026
1028
1031
1032
1033
1034
1035
1037
1038
1039
1041
1042
1043
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1058
1059
1060
1061
1062
1063
1064
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1078
1079
1080
1081
1082
1084
1085
1086
1087
1088
1090
1091
1092
1093
1094
1096
(and many more)
tobiasehlert commented 10 months ago

Thanks for reporting @mathiasbynens ⭐

mathiasbynens commented 10 months ago

Thanks for the quick fix!

Can’t wait for this to reach production :) I see e.g. https://api.tibiadata.com/v3/news/id/504 and https://api.tibiadata.com/v4/news/id/504 are still on an older commit.

tobiasehlert commented 10 months ago

Thanks for the quick fix!

Can’t wait for this to reach production :) I see e.g. https://api.tibiadata.com/v3/news/id/504 and https://api.tibiadata.com/v4/news/id/504 are still on an older commit.

@mathiasbynens, now the new versions are deployed :)

mathiasbynens commented 10 months ago

Yaaay! Thanks 👍

mathiasbynens commented 10 months ago

Just noticed some IDs still result in empty content/content_html on v3: https://api.tibiadata.com/v3/news/id/891

v4 is fine: https://api.tibiadata.com/v4/news/id/891

mathiasbynens commented 10 months ago

…and now v3 returns non-empty results as well. Not sure what happened but everything seems to work as expected now 🥳

tobiasehlert commented 10 months ago

…and now v3 returns non-empty results as well. Not sure what happened but everything seems to work as expected now 🥳

caching was maybe the issue there.. not sure. all pods are restarted with the right versions as I can see :)