feat: fixed the issue #311 the wrong code status

TibiaData / tibiadata-api-go

TibiaData API written in Golang and deployed in container (version v3 and above).

https://api.tibiadata.com

MIT License

79 stars 26 forks source link

feat: fixed the issue #311 the wrong code status #329

Closed Pvmendes closed 4 months ago

Pvmendes commented 5 months ago

I changed the switch case from a TibiaDataErrorHandler function to return the correct status code.

it's a small fix, but I wanted to know your feedback.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tobiasehlert commented 4 months ago

Closing this, since there is already PR #309 resolving the same problem. Didn't merge it back then, since this would introduce breaking change. V5 will include this feature though which is probably coming in early summer 2024. Thanks for your contribution @Pvmendes