search

Tibolte / ElasticDownload

We are not Gif makers, We are developers
1.65k stars 266 forks source link

Added the ability to set the background color #34

Closed PGMacDesign closed 8 years ago

PGMacDesign commented 8 years ago

Added 2 methods for setting the background color of the Elastic view. It should take in either an int color or a String and parse the color. If the string is null or the parsing fails, nothing will be set and it will retain the original color

I created a pull request into the bugfix branch (not master) so you can update after testing if you would like. I tested it myself before pushing and it seems to have no issues that I can find.

Tibolte commented 8 years ago

You're doing a PR into the wrong branch, don't target _restorestate but master. That reminds me I have to delete this old branch :)

PGMacDesign commented 8 years ago

Ha. Apologies, I'll make a pull request to master

PGMacDesign commented 8 years ago

Updated with new pull: https://github.com/Tibolte/ElasticDownload/pull/35 Thanks!

PGMacDesign commented 8 years ago

I see that the merge went through, but it looks like the gadle / maven builds are still the old version. Any chance you could update the file whenever you have some free time? Thanks!

Tibolte commented 8 years ago

Yes good point I'll try to do that asap and publish a new version.