TicTac7x / runelite-plugins

External plugins for RuneLite
https://runelite.net/plugin-hub/
11 stars 14 forks source link

Charge count on some items decreases while they are banked #107

Closed fuzxi closed 9 months ago

fuzxi commented 11 months ago

I'm not sure how to replicate this. Every so often (1-2 days), my bonecrusher necklace with 74k charges will display 73k despite not having taken it out of the bank. Checking it will reset it to the correct value, and then the charge counter will show 73k again a few days later. I've seen similar things with other items that carry a large number of charges, like the ring of suffering (ri) and ash sanctifier. I don't have any duplicates of these items with different charge counts, and I haven't logged into another account that has any of these items.

Expected behavior Charge counts should not change while the item is stored in the bank.

Screenrecording/Screenshots 2023-11-04-15-53-51 2023-11-04-15-54-04

TicTac7x commented 11 months ago

Major revamp of the code coming out in few days, hopefully that will resolve the issue, no clue how it could happen for now tho

This is the same bug as with ash sanctifier (https://github.com/TicTac7x/runelite-plugins/issues/103), i forgot that i decliend and skipped the release of v0.4 of the plugin (where it was already fixed), because i was already working on the 0.5 by the time it hadn't made to the plugin hub.

Bonecrusher charges decrease on every time you lose a prayer point currently, which will be fixed in the new major release!

TicTac7x commented 11 months ago

https://github.com/runelite/plugin-hub/pull/5187