search

TicTac7x / runelite-plugins

External plugins for RuneLite
https://runelite.net/plugin-hub/
11 stars 14 forks source link

A collection of bugs #109

Closed Rowan-Mulder closed 7 months ago

Rowan-Mulder commented 11 months ago

Hi, I found a few bugs that I'd like to list here. I hope this different format of a bug report is alright. No rush, certainly with Leagues around the corner. If desired, I can try to have a crack at pushing some changes myself and sending a merge request.

1: Similar items share charges (Trident of the seas (partially charged) and Trident of the Swamp (partially charged)) image (Crystal halbert (full and partially charged)) image (Ring of shadows (both partially charged)) image

2: Gembag often doesn't update image image Same applies for manually filling it.

3: Slayer ring charged+taskcount overlap (with default Slayer plugin) image The RuneLite Slayer plugin (assumed to be used by many and turned on by default) its task count overlaps with the teleport charges. (I'm assuming this isn't much of a problem, as some may like this, but could perhaps be disabled by default)

4: Missing charges (some nice-to-haves, others more useful) (Venator bow) image (Blood fury) image (Magma helm (possibly other variants too)) image (Slayer's staff (e)) image (Warped sceptre) image (Ring of the elements) image (Gnomish firelighter (filled)) image

5: Camulet+Ardy cape sometimes don't show infinite charges, especially camulet. (Top: Inventory, Bottom: bank) image

6: (Optional if possible) Modified config GUI; Checkboxes instead of multi-select lists. image Prevents accidentally resetting all changed and may be slightly clearer to see what's on/off due to contrast issues on some monitors.

If more information is required or this format isn't desired, please let me know how I can help. Thanks for reading!

TicTac7x commented 11 months ago

Hey, thanks for the detailed list of issues.

  1. There is no easy way to track which item is which, at least as far as I know.
  2. Storage items like gem bag, herb sack, etc are going to have a lot better support with the upcoming next release (https://github.com/runelite/plugin-hub/pull/5187). This update is going to track what items exactly are inside the storage item and it will be also possible to see what items are inside it by hovering on it. image
  3. Its probably good suggestion indeed to disable the charges overlay for slayer ring by default, since the official slayer plugin is probably used by most.
  4. Lets create separate issues for all of these items, since we need to gather all in game messages/animations etc for those items. It would clutter this issue up by a great margin.
  5. I have disabled showing the unlimited charges for now, but i guess it would be good idea to make it optional. Hopefully the items will behave charges wise better with the next update that is currently in PR.
  6. I guess this makes sense, the multi-select list is a known trouble-maker.

So to summarize what will be done regarding this issue:

Forgot to also wrote that if you are interested of helping out, feel tree to, im happy to check out your PR. You can let me know in here if you do decide to try to work on something, so i know and can avoid working on same things.

TicTac7x commented 7 months ago

Closing and creating separate issue to show/hide unlimited charges. Checkboxes already has separate issue created. Other things wont be worked on.