search

TicTac7x / runelite-plugins

External plugins for RuneLite
https://runelite.net/plugin-hub/
11 stars 14 forks source link

Kharedst memoirs- not updating on check #132

Closed Jtcoope19 closed 6 months ago

Jtcoope19 commented 8 months ago

Describe how the bug happened

  1. ... checking memoirs
  2. ... still showing, "?" in corner

Expected behavior To display the number of charges remaining.

TicTac7x commented 8 months ago

Can you send screenshot of the check message again please? I'll take a look again

TicTac7x commented 7 months ago

Can't really debug this since i have the book of the dead. I thought i fixed it during leagues, but seems like not. I need someone with the Kharedst memoirs to help me debug this.

Araevin commented 7 months ago

This is happening for me with the book of the dead as well. Did it not used to say the total number of possible charges, as a fraction? Could be they updated it.

book-of-the-dead-check-message
Jtcoope19 commented 7 months ago

Looks like they changed it. Judging by the the picture it was a fraction at one point

TicTac7x commented 7 months ago

Can confirm, the message is different now. Here's the check regex that used to work previously: "On the inside of the cover a message is displayed in dark ink. It reads: (?<charges>.+) (memories|memory) remain." Looks like they have added the /250 to the end of it, i will update it, thanks for finding this.

I need someone to send screenshot of the same message from kharedst memoirs instead of book of the dead tho

Guess we will also need to double check all other messages for that item to be sure, heres the list of them:

            new OnChatMessage("You add an entry to Kharedst's Memoirs.").increaseCharges(8),

            // Teleport.
            new OnChatMessage("((Kharedst's Memoirs?)|(The Book of the Dead)) now has (?<charges>.+) (memories|memory) remaining.").setDynamically(),

            // Check empty.
            new OnChatMessage("((Kharedst's Memoirs?)|(The Book of the Dead)) holds no charges?.").fixedCharges(0),

            // Check.
            new OnChatMessage("On the inside of the cover a message is displayed in dark ink. It reads: (?<charges>.+) (memories|memory) remain.").setDynamically(),

            // Charge.
            new OnChatMessage("((Kharedst's Memoirs?)|(The Book of the Dead)) now has (?<charges>.+) charges.").setDynamically(),

            // Try to charge book of the dead when already full.
            new OnChatMessage("The Book of the Dead is already fully charged").fixedCharges(60),

            // Try to charge kharedst memoirs when already full.
            new OnChatMessage("The Kharedst's Memoirs? is already fully charged").fixedCharges(40),

And also, did they increase the max amount of charges, it wasn't 250 before?

Oh... image

Araevin commented 7 months ago
memior-charge-when-full memior-check-full memior-fully-charge memior-teleport-1-remaining memior-check-empty memior-teleport memior-check
TicTac7x commented 7 months ago

Thank you, these were super helpful!

TicTac7x commented 7 months ago

https://github.com/runelite/plugin-hub/pull/5769

TicTac7x commented 7 months ago

https://github.com/runelite/plugin-hub/pull/5783

TicTac7x commented 6 months ago

Please let me know, if it works now!

Araevin commented 6 months ago

It appears to work now. Checking and teleporting with the memoirs shows the current charges now. Checking, recharging, and teleporting with the book of the dead shows charges too now. (I didn't thoroughly check every possibility though) Thank you