TicTac7x / runelite-plugins

External plugins for RuneLite
https://runelite.net/plugin-hub/
11 stars 14 forks source link

Gem Bag - Depositing into bank doesn't set Gem Bag charges to 0 #162

Closed ADCogburn closed 3 months ago

ADCogburn commented 5 months ago

Describe how the bug happened

  1. Collect Gems in Gem Bag
  2. Go to a bank or deposit box
  3. Right-click on the Gem Bag, and click "Empty" (into the bank)

This empties the bag and puts all of the gems into the bank, but the gem bag 'charges' does not change. If you click "Empty" again, you get the chat message "The gem bag is empty." This then does properly reset the 'charges' to 0. If, instead of clicking "Empty" again, you exit from the bank/deposit box interface and right-click and click "Check" it says, "The gem bag is empty" and the 'charges' is properly reset to 0.

Expected behavior When depositing gems from the gem back directly into the bank (both from a bank interface or a deposit box) by clicking "Empty", the 'charges' overlay on the gem back should change to 0 without having to do additional empties/checks just for the chat dialogue to 'confirm' that it's empty.

Screenrecording/Screenshots In the video I show myself with a filled gem back that I empty into the bank and the 'charges' does not reset to 0 as expected. After 'checking' the bag it does reset (even though it was 0 after hitting "Empty").

https://github.com/TicTac7x/runelite-plugins/assets/114529590/0f6a8dc7-e02c-40ec-ab13-60dacc4e9046

TicTac7x commented 5 months ago

https://github.com/runelite/plugin-hub/pull/6107