Item Charges Improved - Waterskin infobox only showing 1st waterskin

TicTac7x / runelite-plugins

External plugins for RuneLite

https://runelite.net/plugin-hub/

10 stars 11 forks source link

Item Charges Improved - Waterskin infobox only showing 1st waterskin #167

Closed Koslas1 closed 4 days ago

Koslas1 commented 3 months ago

Describe how the bug happened

Have multiple waterskins in your inventory
Infobox for the waterskins only shows the amount of water in the 1st waterskin
If the 1st waterskin is empty, but others are filled, the infobox will say 0

Expected behavior Have the total amount of water in all waterskins written in the infobox. For example having 2x waterskin (0) 1x waterskin (1) = 1 water 5x waterskin (4) = 20 water That would then show up as 21 in the infobox for waterskins

Screenrecording/Screenshots Screenshot 2024-05-18 222548

TicTac7x commented 3 months ago

https://github.com/runelite/plugin-hub/pull/6107

Koslas1 commented 2 months ago

If I have 6 waterskins(4) It correctly shows up as 24 worth of waterskins, however once the first one changes to a waterskin(3) the infobox only displays a total count of 3. I'm assuming it may of been to do with your change just adding waterskin(4) together to get 24, however it should get the total count from doing SUM( MULTIPLY( Amount of waterskin(4), 4), MULTIPLY( Amount of waterskin(3), 3), MULTIPLY( Amount of waterskin(2), 2), Amount of waterskin(1))

TicTac7x commented 3 weeks ago

https://github.com/runelite/plugin-hub/pull/6486