search

TicTac7x / runelite-plugins

External plugins for RuneLite
https://runelite.net/plugin-hub/
11 stars 14 forks source link

Forestry Kit should display remaining Forester's rations or other chosen item #168

Closed telans closed 3 months ago

telans commented 5 months ago

Currently the Forestry kit displays unlimited charges.

Screenshot_20240518_224948

I'm not sure what this value is referring to, is it a placeholder?

https://github.com/TicTac7x/runelite-plugins/blob/82446ba67dbcfaf5d52f8c6b83261377c40fbbe1/src/main/java/tictac7x/charges/items/C_ForestryKit.java#L35

It would be good if it could display the number of Forester's rations remaining. This is helpful for people that use the kit primarily as a method to restore run energy.

I.e., for the following case display "755" as the count:

Screenshot_20240518_225429

Alternatively, options to display the count of a particular item stored within would be good. I'm not familiar with the RuneLite api so I'm not sure if this count is exposed anywhere.

I'm willing to implement it if you could please point me to the correct api for doing so.

TicTac7x commented 5 months ago

Thanks for the suggestion, it's a good one. The item was originally implemented as a placeholder for future once I managed to get items with storage working (for example gem bag, herb sack, etc, which now support storage logic).

If you are interested in helping out, then you can fork my repo, check out how gem bag was implemented for example, and then try to implement the forestry kit and eventually open PR for it. You can also find me from runelite discord, if you need additional help.

TicTac7x commented 5 months ago

image

:eyes:

TicTac7x commented 5 months ago

https://github.com/runelite/plugin-hub/pull/6107

TicTac7x commented 3 months ago

It's currently showing all items inside the forestry kit, you can't choose specific item to show. Might add the specific feature later, where you can choose what item to show, not sure yet.