search

TicTac7x / runelite-plugins

External plugins for RuneLite
https://runelite.net/plugin-hub/
11 stars 14 forks source link

Strange old lockpick - Request #93

Closed call-me-maple closed 9 months ago

call-me-maple commented 1 year ago

Link Link to osrs wiki for the item: wiki

Screenshots Provide screenshots that are available to the item that you are requesting with all in-game messages shown.

  1. Item has no charges, check the charges N/A - The item is destroyed when fully empty

  2. Item has 1 charge, check the charges RuneLite_Crrfq8Crk4 image

  3. Item has some charges, check the charges RuneLite_uCWkkLtpsk

  4. Item has full charges, check the item The item has a different name when full and tradable. RuneLite_L25TpbnsHc RuneLite_5AJnlZDxcN

  5. Do an actions that increases/decreases charges when used Kinda lame but there isn't a game message for a charge being used. The charge is consumed only on the first door of each pair too... It could be there is some sort of 1/2 charge system too but didn't test this. RuneLite_XTsBlMXKcO https://github.com/TicTac7x/runelite-plugins/assets/85463994/0346a26b-52e0-47f9-9d1e-a96de4559daf

  6. Empty the item of charges N/A

  7. Fill the item with 1 charge N/A

  8. Fill the item with some charges N/A

  9. Fill the item so it has full charges N/A

  10. Activate the item N/A

  11. Deactivate the item N/A

  12. Anything else where charges are mentioned or changed There are some messages when degraded to specific intervals it looks like. Presumably every 5 till the last 3 charges. (I play on an iron and kinda feels bad to just waste charges so didn't test from 50 charges but the interval it shows at shouldn't be a problem with some regex grouping and reading the value out) image image image image image image image This is the message for when you get between the doors on your last charge so you don't get trapped image The inspection does change to 0 too image And after using it to get out from between the doors this message and crumbles image

It looks like the intervals are regular enough to rely on the game messages still if you are okay with having some uncertainty in the charge value. Otherwise, I think you would have to subscribe to the menu option clicks and check what item it was and if it was used on one of the correct doors to subtract a charge. Curious what you think. Hope this this is enough info :)

TicTac7x commented 1 year ago

Thanks for the very detailed info and the video, sorry that you had to waste the charges like that :D

I will add it with initial info in (without decreasing automatically by 1 at the door, need to debug and test to find reliable enough method for that).

call-me-maple commented 1 year ago

I didn't waste them :) I just did like 30 barrows kc slowly using it lol. But my lowest charge one started around 25 and I didn't want it to take up multiple bank spots :p

What do you think about indicating when the charges aren't known exactly in some way? I worry that people might open bug reports if it just displays the wrong value sometimes. Maybe like '<=10', '<11', '10-5', '~10' or something

TicTac7x commented 1 year ago

Im going to add the item in initially for now (without decreasing charge at every door) and only updating based on the chat messages.

TicTac7x commented 1 year ago

https://github.com/runelite/plugin-hub/pull/5096

TicTac7x commented 11 months ago

https://github.com/runelite/plugin-hub/pull/5187