Tichau / FileConverter

File Converter is a very simple tool which allows you to convert and compress files using the context menu in windows explorer.
https://file-converter.io/
GNU General Public License v3.0
6.45k stars 510 forks source link

Maximum files limit? #86

Closed warmwhisky closed 6 months ago

warmwhisky commented 5 years ago

I cannot seem to get this to work when I select 460 files. Seems to work with a few like 20 or so.

It has been working fine until today I installed on a windows 10 server workstation. When I choose my preset there is just no response. I tried it on a folder that was not so deep in the server and still the same. Strangely the "configure presets" is also not popping up when I click it after it has failed.

Seems to be doing it on my Windows 7 machine also.

I am trying to downsize jpg by 25% only.

ivellios1988 commented 4 years ago

Same thing happened to me on Windows 10. File Converter just didn't start until I deselected some files.

Cipriux commented 1 year ago

I think I found the reason: The selected files full path list should not be bigger than 32k something characters Here is my exact example with empirical testing, this is the exact maximum limit that works on my selections So there are 445 files selected with the following path structure of maximum character size: 31793 + 445*2 = 32683 I am guessing the limit should be 2^15 = 32768 minus some control characters or memory for some variables

001:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_001.png 001:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_002.png ... 444:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_444a.png 445:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_445a.png

Making the file path shorter, I managed to convert around 2000 files at once: f:\1\0001.png f:\1\0002.png ... f:\1\1984.png f:\1\1985.png

I used Total Commander to copy file path list and Sublime Text with LaTeX Word Count plugin to count the characters I hope it helps someone

Tichau commented 8 months ago

Since FileConverter is launch by command line, there is a limitation about the size the string containing the arguments.

To allow more conversion to be done, we should implement a way of passing files to convert in a text file. For example: --conversion-preset "To Small Jpg" --input-files "C:\Path\To\Text\File\Containing\Files\List"

mesheets commented 8 months ago

Might there perhaps be a way to have FileConverter act on files in a directory, possibly with a recursive option? For example, provide:

In @Cipriux's example, the files all appear to be under the directory "F:\2_Downloads\down_net_MJ_temp\", so a directory-based approach potentially might address that use case.

Tichau commented 8 months ago

This request has been done here if you want to had info: issue #94