Closed spencer516 closed 7 years ago
Looks like most of these changes are tests and processing in lib/
, so I'll take my time reviewing those later, but an immediate question I have is, how does this handle dynamically created class names?
@tf-button--${group}
isn't enough here.
For now, it'd just be a matter of importing the "classifier" directly — so, in your example:
import classify from 'ember-css-composer/classify';
....
buttonCategory: computed('utilityGroups', {
get() {
return get(this, 'utilityGroups')
.compact()
.map(group => classify(`tf-button--${group}`))
.join(' ');
}
})
Though, I do want to put some more thought into that.
@ksin @BrianSipple @melissaroman
There's a ton to review here. I'll go through and make some initial notes to clarify what's going on here.