search

Ticketfly-UI / ember-css-composer

CSS Class Name Macros
MIT License
2 stars 0 forks source link

@compose inside CSS. #4

Closed spencer516 closed 7 years ago

spencer516 commented 7 years ago

Made a change so that the @compose rules can be declared anywhere in the CSS (rather than in separate .css-config files).

ksin commented 7 years ago

Not really a critique, but can you clarify what the fixtures are for? I can't seem to follow how they're used

spencer516 commented 7 years ago

@ksin — the fixtures are used for the tests to assert input/output of the file transformations that happen in Broccoli. They're referenced in each of the test helper files (node-test/helpers/{clean-compose-css-file.js,transform-babel-file.js,transform-css-tree.js}).

Those helpers were made to reduce some boilerplate in writing the file-transform tests.

Perhaps "fixtures" isn't the right word to describe them? I borrowed that pattern from how lots of PostCSS plugins write their tests (example: https://github.com/postcss/postcss-color-hwb/tree/master/test/fixtures)