search

Tidal-Stream / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
8 stars 15 forks source link

Another fix for the SRB nozzle color #8

Closed rsparkyc closed 6 years ago

rsparkyc commented 6 years ago

I think this was the commit that changed the SRB nozzle: https://github.com/Tidal-Stream/ProceduralParts/commit/991e7358fa2d2dd842ed7564c0cf1203be7528f9

I've pretty much reverted the logic that was done there, while retaining the change from float -> double.

Tidal-Stream commented 6 years ago

Great. So this one is a better fix than the alternative patch? I will test it when I can with stock and with RealismOverhaul. Can you replace the tabs with spaces? The indentation of the changed lines looks off. You can see it here. And since RealismOverhaul is available only on 1.3, it would be easier for testing to keep PRs based on branch master and port them to 1.4 after that. This fix should work on both, right?

rsparkyc commented 6 years ago

Yeah, I can make those changes. I’d like to give @stasikos a chance to look at this too and get his thoughts since he made the other PR