TiddlySpace / tiddlyspace

A discoursive social model for tiddlers
http://tiddlyspace.com
Other
106 stars 38 forks source link

non-unicode policy data in instance.py causes warnings in sqlalchemy #1040

Open cdent opened 11 years ago

cdent commented 11 years ago

The data model expects (correctly) unicode, so when it receives str it gets annoyed and announced a warning. These warnings don't impact service, but they do make effective testing harder (where one would prefer all warnings to be treated as errors with tracebacks).

I'm not sure where the best place to enforce unicode policy or do str->unicode transformation should be:

Option 1 is most explicit and thus probably best but means the instance file needs u'' all over it. Option 2 is hard to do with the simple data only classes that TiddlyWeb desires. Option 3 has a magic at a distance feel.

/cc @FND @pads

FND commented 11 years ago

I'm not sure where the best place to enforce unicode policy or do str->unicode transformation should be:

  • at the source data (that is, in the instance file)
  • in the model classes
  • in the Storage implementation

Remind me: Is there some component that processes instance.py which might do the transformation?

The model or storage implementations seem like the wrong layer for this.

Either way, I don't see this as much of a problem:

Option 1 is most explicit and thus probably best but means the instance file needs |u''| all over it.

Of course if we were using Python 3...

cdent commented 11 years ago

imaker and/or ibuilder (the instancer replacements) mess with the instance.py data.