search

TiddlySpace / tiddlyspace

A discoursive social model for tiddlers
http://tiddlyspace.com
Other
106 stars 38 forks source link

RandomColorPaletteMacro drops Error slice #205

Closed FND closed 13 years ago

FND commented 14 years ago

It appears that ColorPalette tiddlers generated recently by RandomColorPaletteMacro lack the Error slice. (ColorPalettes in some of my less recent spaces seem fine.)

This is problematic because errors then lack visual highlighting.

In order to fix existing spaces, we either have to amend their ColorPalettes or perhaps add a default value to some style sheet.

NB: In order to be future-proof, RandomColorPaletteMacro should make sure it has values for all default slices.

jdlrobson commented 14 years ago

fixed in 1.2.3

FND commented 14 years ago

I assume you're referring to your plugin - what about fixing existing spaces?

jdlrobson commented 14 years ago

this just comes down to priorities... this is way down my list at the moment.

cdent commented 13 years ago

If an old ticket is not going to be acted upon, please close it.

If it does need action then please do tickets in chronological order unless there are data destroying bugs which would otherwise take precedence. Do not let new features take precedence over tickets please.

jdlrobson commented 13 years ago

at worst some css rules will not work for users with palettes generated prior to 1.2.3. I really don't see this as a major problem.

In cases where omitting the error causes a major problem to a layout A css rule along the lines of: .class { color: red; color: [[ColorPalette::Error]]; } should suffice (if there is no Error slice then the rule becomes invalid and red will be used). If there is then the Error slice should be used.

I would be thus in favour of closing this, as the gain from updating existing palettes (making a few css rules work) doesn't seem worth the aggravation (vanishing SiteIcon's springs to mind).