TiddlyWiki / TiddlyDesktop

A custom desktop browser for TiddlyWiki 5 and TiddlyWiki Classic, based on nw.js
1.63k stars 121 forks source link

[feature request + demo] Update and improve the backstage by adding the tagpicker UI to the WikiListRow template + a search field #260

Closed Telumire closed 1 year ago

Telumire commented 1 year ago

It would be nice to be able to filter the wiki list based on tags and on the title name. I made a very quick proof of concept.

Drag and drop this json into your backstage: https://talk.tiddlywiki.org/uploads/short-url/200VvKMC5I04nVNoqRijvsyqzdv.json

This add a search field with a clear button, a list of tags to search by tag, and the tag picker UI on each wiki listed to add and remove tags :

image

Clicking on the work tagpill :

image

Then on the school tagpill :

image

We can also search by text in the title of the wiki :

image

See https://talk.tiddlywiki.org/t/call-for-tiddlydesktop-new-functionality/5334/12?u=telumire for a discussion on this feature request

Jermolene commented 1 year ago

Hi @Telumire that is a great idea, is it something you could work on?

Jermolene commented 1 year ago

Apologies @Telumire I'd missed that you had posted an implementation in the talk thread. Please do go ahead and create a PR if you have the time, thank you.

Telumire commented 1 year ago

Hi @Jermolene, I'll do it this weekend. By the way, I noticed that the backstage use TW 5.1.23-prerelease, would it be possible to update it to the 5.2.4-prerelease ? I wish I could use the let widget, filter prefix, checkbox listfield, etc.

Jermolene commented 1 year ago

Hi @Jermolene, I'll do it this weekend. By the way, I noticed that the backstage use TW 5.1.23-prerelease, would it be possible to update it to the 5.2.4-prerelease ? I wish I could use the let widget, filter prefix, checkbox listfield, etc.

I've updated package(-lock).json in https://github.com/TiddlyWiki/TiddlyDesktop/commit/010d2ebc7517a41cabac9b4a7c85ca0301f25b43 – we can release a new prerelease when we merge this feature.

Telumire commented 1 year ago

@Jermolene, in order to create a PR I tried to edit the backstage of the latest prerelease and it seems like there are some bugs:

Field value can not be edited / added :

image

Creating a tiddler doesnt close the tiddler when the "confirm changes to this tiddler" button is pressed

Sometimes there are empty tiddlers frame in the storylist

image

This issue does not appear in the previous prerelease.

Should I create a PR anyway ?

Jermolene commented 1 year ago

Thank you @Telumire that seems like a significant problem in its own right – if you right click on the page and choose "inspect" you'll see a bunch of error messages. I'll investigate further.

image
Jermolene commented 1 year ago

Hi @Telumire that bug is fixed now. Do you need me to publish a new build or are you able to run the build process locally?

Telumire commented 1 year ago

@Jermolene I tried to build tiddlydesktop myself but it seems like I need to use the Windows Subsystem for Linux to run download-nwjs.sh, which I did, but I'm not able to run the file (it just open in a my code editor). So yes, if you could publish a new version, it would be useful :)

Jermolene commented 1 year ago

No problem @Telumire I'll make a new build now.

Jermolene commented 1 year ago

Hi @Telumire the new build is available here:

https://github.com/TiddlyWiki/TiddlyDesktop/releases/tag/v0.0.15-prerelease.5

Let me know if you run into any issues.

Telumire commented 1 year ago

Hello @Jermolene, thanks a lot ! I will test this now and make a PR after polishing a bit more my proposal.

Telumire commented 1 year ago

@Jermolene here's the PR: https://github.com/TiddlyWiki/TiddlyDesktop/pull/262

Jermolene commented 1 year ago

Closing because #262 is merged