TiddlyWiki / TiddlyDesktop

A custom desktop browser for TiddlyWiki 5 and TiddlyWiki Classic, based on nw.js
1.63k stars 121 forks source link

Add search and tag support for the wikilist #262

Closed Telumire closed 1 year ago

Telumire commented 1 year ago

This PR add several changes:

Jermolene commented 1 year ago

Thanks @Telumire I'm trying it out now, looks great and mostly working as expected.

I have three wikis in my file list window. I'm finding that some searches cause two of the wikis to be returned twice, showing a total of five wikis. It's hard to see the pattern. For example, all my wikis have "jer" in the title and the pathname. Searching for "je" returns three wikis, but adding an "r" to search for "jer" returns five wikis.

Aesthetically, I think it might look better to lose the border around the tag box but I do see that that might cause the tag pills to be confused for the command pills. Perhaps any further visual improvements should be a subsequent PR – I'd like to consider alternatives for the command buttons; they take up a lot of space and are distracting. Perhaps a popup menu would be better instead.

Telumire commented 1 year ago

I have three wikis in my file list window. I'm finding that some searches cause two of the wikis to be returned twice, showing a total of five wikis. It's hard to see the pattern. For example, all my wikis have "jer" in the title and the pathname. Searching for "je" returns three wikis, but adding an "r" to search for "jer" returns five wikis.

😬I only tried with two, I will search for a fix !

Aesthetically, I think it might look better to lose the border around the tag box but I do see that that might cause the tag pills to be confused for the command pills. Perhaps any further visual improvements should be a subsequent PR – I'd like to consider alternatives for the command buttons; they take up a lot of space and are distracting. Perhaps a popup menu would be better instead.

I'm going to correct the issues you mentioned, then if I have suggestions to improve the design I'll make a new PR :) I agree that the UI could be improved.

Telumire commented 1 year ago

@Jermolene I was unable to replicate the issue but I added a unique[] filter operator that should take care of duplicates in the list of results.

Jermolene commented 1 year ago

Thanks for your patience @Telumire. It looks good now – I was experiencing some bugs that turned out to be due to the corrupt configuration tiddlers. I'll merge now, and release v0.0.15