TiddlyWiki / TiddlyFox

An extension for older versions of Mozilla Firefox to enable TiddlyWiki to save changes
52 stars 24 forks source link

Doesn't work with firefox for android #3

Closed Anacletus closed 11 years ago

Anacletus commented 12 years ago

The extension installs ok, but it doesn't seem to do anything, doesn't ask for permissions to write the file, and tiddlywiki shows the same error when saving as without the extension

It works ok for me modifying the overlay.js file. In the onload event, appcontent is null, and no onPageLoad event is registered. Adding a few lines that test appcontent for null and tryies to load it with another elementid seems to work ok:

onLoad: function(event) { // Register a page load event var appcontent = document.getElementById("appcontent"); if (!appcontent) { //This seems to work on android (fennec): appcontent = document.getElementById("browsers"); // Fennec } ...

This solution is based on code from:

http://stackoverflow.com/questions/5180634/how-to-listen-to-page-loads-from-fennec-extension

By the way, great extension! thx!

Jermolene commented 12 years ago

Terrific! That's incredibly helpful (I don't have an Android device to test on). I'll issue a new version with this change shortly. Many thanks for your contribution.

Jermolene commented 11 years ago

Hi @Anacletus, apologies for the delay, I've just posted an update to TiddlyFox incorporating your fix in 1ebf55df68709cb293d9557ca72fbd9e376bb728

Cheers

Jeremy

Anacletus commented 11 years ago

I've installed the xpi and keeps working for me. Thx!