search

TiddlyWiki / TiddlyFox

An extension for older versions of Mozilla Firefox to enable TiddlyWiki to save changes
52 stars 24 forks source link

TiddlyFox crashes FireFox 44 developer edition #35

Open trevor-ratliff opened 9 years ago

trevor-ratliff commented 9 years ago

Issue

I first noticed some strange behavior with FireFox dev edition when it updated to the 44 version. It seemed like sites would crash for no reason, then I had the whole browser go down - and I thought it was something buggy with the new version of the browser. Then I started getting crashes when I first tried opening the browser - nothing would open, it would crash right away. I was able to get FF to open in safe mode and visit all the tabs without issues. So I started looking at plug-ins and extensions. As soon as I disabled the TiddlyFox extension the crashes stopped. I don't know what FF changed in version 44, but it doesn't play nice with TiddlyFox. Once I figured this out I could enable TiddlyFox and not visit any TiddlyWikis and be fine, but as soon as I went to one it would crash the browser.

I hope this isn't a hint of things to come to the main FireFox as I have to use FF version 42 to run a TiddlyWiki using TiddlyFox right now. I thought FireFox Dev 43 worked as well, but I don't remember.

Reproduce

Accessibility: Active
AdapterDeviceID: 0x0412
AdapterDriverVersion: 10.18.15.4256
AdapterSubsysID: 05a41028
AdapterVendorID: 0x8086
Add-ons: tiddlyfox%40tiddlywiki.org:1.0alpha18.1-signed,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D:44.0a2
AvailablePageFile: 11360059392
AvailablePhysicalMemory: 10791120896
AvailableVirtualMemory: 3598069760
BIOS_Manufacturer: Dell Inc.
BlockedDllList: 
BreakpadReserveAddress: 70582272
BreakpadReserveSize: 67108864
BuildID: 20151111004055
CrashTime: 1447345811
DOMIPCEnabled: 1
EMCheckCompatibility: true
FramePoisonBase: 00000000f0de0000
FramePoisonSize: 65536
IPCFatalErrorMsg: unknown union type
IPCFatalErrorProtocol: PJavaScriptParent
InstallTime: 1447253580
MozCrashReason: MOZ_CRASH(IPC FatalError in the parent process!)
Notes: AdapterVendorID: 0x8086, AdapterDeviceID: 0x0412, AdapterSubsysID: 05a41028, AdapterDriverVersion: 10.18.15.4256
DWrite? DWrite+ D2D1.1? D2D1.1+ D2D? D2D1.1V? D2D1.1V+ D2D+ D3D11 Layers? D3D11 Layers+ 
ProductID: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
ProductName: Firefox
ReleaseChannel: aurora
SafeMode: 0
SecondsSinceLastCrash: 179242
StartupTime: 1447345781
SystemMemoryUsePercentage: 36
TelemetryEnvironment: {"build":{"applicationId":"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}","applicationName":"Firefox","architecture":"x86","buildId":"20151111004055","version":"44.0a2","vendor":"Mozilla","platformVersion":"44.0a2","xpcomAbi":"x86-msvc","hotfixVersion":null},"partner":{"distributionId":null,"distributionVersion":null,"partnerId":null,"distributor":null,"distributorChannel":null,"partnerNames":[]},"system":{"memoryMB":16290,"virtualMaxMB":4096,"cpu":{"count":8,"cores":4,"vendor":"GenuineIntel","family":6,"model":60,"stepping":3,"l2cacheKB":256,"l3cacheKB":8192,"speedMHz":3592,"extensions":["hasMMX","hasSSE","hasSSE2","hasSSE3","hasSSSE3","hasSSE4_1","hasSSE4_2"]},"os":{"name":"Windows_NT","version":"10.0","locale":"en-US","servicePackMajor":0,"servicePackMinor":0,"installYear":2015},"hdd":{"profile":{"model":"Samsung SSD 850 PRO 512GB","revision":"EXM02B6Q"},"binary":{"model":"Samsung SSD 850 PRO 512GB","revision":"EXM02B6Q"},"system":{"model":"Samsung SSD 850 PRO 512GB","revision":"EXM02B6Q"}},"gfx":{"D2DEnabled":true,"DWriteEnabled":true,"adapters":[{"description":"Intel(R) HD Graphics 4600","vendorID":"0x8086","deviceID":"0x0412","subsysID":"05a41028","RAM":null,"driver":"igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32","driverVersion":"10.18.15.4256","driverDate":"7-17-2015","GPUActive":true}],"monitors":[{"screenWidth":1920,"screenHeight":1080,"refreshRate":60,"pseudoDisplay":false},{"screenWidth":1920,"screenHeight":1080,"refreshRate":60,"pseudoDisplay":false}],"features":{"compositor":"none","d3d11":{"status":"available","version":45312,"warp":false,"textureSharing":true,"blacklisted":false},"d2d":{"status":"available","version":"1.1"}}},"isWow64":true},"settings":{"blocklistEnabled":true,"e10sEnabled":true,"telemetryEnabled":true,"isInOptoutSample":false,"locale":"en-US","update":{"channel":"aurora","enabled":true,"autoDownload":false},"userPrefs":{"app.update.auto":false,"browser.cache.disk.capacity":358400,"browser.newtabpage.enhanced":true,"browser.shell.checkDefaultBrowser":false,"browser.startup.page":3,"privacy.donottrackheader.enabled":true},"addonCompatibilityCheckEnabled":true,"isDefaultBrowser":false},"profile":{"creationDate":16693},"addons":{"activeAddons":{"tiddlyfox@tiddlywiki.org":{"blocklisted":false,"description":"A Firefox extension to enable TiddlyWiki to save changes directly to the file system.","name":"TiddlyFox extension for Firefox","userDisabled":false,"appDisabled":false,"version":"1.0alpha18.1-signed","scope":1,"type":"extension","foreignInstall":false,"hasBinaryComponents":false,"installDay":16694,"updateDay":16743,"signedState":1}},"theme":{"id":"{972ce4c6-7e08-4474-a285-3208198ce6fd}","blocklisted":false,"description":"The default theme.","name":"Default","userDisabled":false,"appDisabled":false,"version":"44.0a2","scope":4,"foreignInstall":false,"hasBinaryComponents":false,"installDay":16693,"updateDay":16750},"activePlugins":[{"name":"Google Update","version":"1.3.28.15","description":"Google Update","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/x-vnd.google.update3webcontrol.3","application/x-vnd.google.oneclickctrl.9"],"updateDay":16692},{"name":"Microsoft Office 2013","version":"15.0.4514.1000","description":"The plugin allows you to have a better experience with Microsoft SharePoint","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/x-sharepoint","application/x-sharepoint-uc"],"updateDay":16693},{"name":"Microsoft Office 2013","version":"15.0.4703.1000","description":"The plugin allows you to have a better experience with Microsoft Lync","blocklisted":false,"disabled":false,"clicktoplay":false,"mimeTypes":["application/vnd.microsoft.communicator.ocsmeeting"],"updateDay":16693},{"name":"Java(TM) Platform SE 8 U65","version":"11.65.2.17","description":"Next Generation Java Plug-in 11.65.2 for Mozilla browsers","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/x-java-applet","application/x-java-bean","application/x-java-vm","application/x-java-applet;version=1.1.1","application/x-java-bean;version=1.1.1","application/x-java-applet;version=1.1","application/x-java-bean;version=1.1","application/x-java-applet;version=1.2","application/x-java-bean;version=1.2","application/x-java-applet;version=1.1.3","application/x-java-bean;version=1.1.3","application/x-java-applet;version=1.1.2","application/x-java-bean;version=1.1.2","application/x-java-applet;version=1.3","application/x-java-bean;version=1.3","application/x-java-applet;version=1.2.2","application/x-java-bean;version=1.2.2","application/x-java-applet;version=1.2.1","application/x-java-bean;version=1.2.1","application/x-java-applet;version=1.3.1","application/x-java-bean;version=1.3.1","application/x-java-applet;version=1.4","application/x-java-bean;version=1.4","application/x-java-applet;version=1.4.1","application/x-java-bean;version=1.4.1","application/x-java-applet;version=1.4.2","application/x-java-bean;version=1.4.2","application/x-java-applet;version=1.5","application/x-java-bean;version=1.5","application/x-java-applet;version=1.6","application/x-java-bean;version=1.6","application/x-java-applet;version=1.7","application/x-java-bean;version=1.7","application/x-java-applet;version=1.8","application/x-java-bean;version=1.8","application/x-java-applet;jpi-version=1.8.0_65","application/x-java-bean;jpi-version=1.8.0_65","application/x-java-vm-npruntime","application/x-java-applet;deploy=11.65.2","application/x-java-applet;javafx=8.0.65"],"updateDay":16736},{"name":"Java Deployment Toolkit 8.0.650.17","version":"11.65.2.17","description":"NPRuntime Script Plug-in Library for Java(TM) Deploy","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/java-deployment-toolkit"],"updateDay":16736},{"name":"Shockwave Flash","version":"19.0.0.226","description":"Shockwave Flash 19.0 r0","blocklisted":false,"disabled":false,"clicktoplay":false,"mimeTypes":["application/x-shockwave-flash","application/futuresplash"],"updateDay":16745},{"name":" Wacom Dynamic Link Library","version":"1.1.0.10","description":"Wacom Dynamic Link Library","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/x-wacom-tablet"],"updateDay":15084},{"name":"WacomTabletPlugin","version":"2.0.0.1","description":"Plugin for Wacom tablets.","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/x-wacomtabletplugin"],"updateDay":15125}],"activeGMPlugins":{"gmp-gmpopenh264":{"version":"1.4","userDisabled":false,"applyBackgroundUpdates":1},"gmp-eme-adobe":{"version":"15","userDisabled":false,"applyBackgroundUpdates":1}},"activeExperiment":{},"persona":"firefox-devedition@mozilla.org"}}
Theme: classic/1.0
Throttleable: 1
TotalPageFile: 19631034368
TotalPhysicalMemory: 17080897536
TotalVirtualMemory: 4294836224
URL: file:///D:/trevor.ratliff/repos/github/other/jobLogBackups/ProgrammerLog2015.html
User32BeforeBlocklist: 1
Vendor: Mozilla
Version: 44.0a2
Winsock_LSP: MSAFD Tcpip [TCP/IP] : 2 : 1 : %SystemRoot%\system32\mswsock.dll 
 MSAFD Tcpip [UDP/IP] : 2 : 2 :  
 MSAFD Tcpip [RAW/IP] : 2 : 3 : %SystemRoot%\system32\mswsock.dll 
 MSAFD Tcpip [TCP/IPv6] : 2 : 1 :  
 MSAFD Tcpip [UDP/IPv6] : 2 : 2 : %SystemRoot%\system32\mswsock.dll 
 MSAFD Tcpip [RAW/IPv6] : 2 : 3 :  
 RSVP TCPv6 Service Provider : 2 : 1 : %SystemRoot%\system32\mswsock.dll 
 RSVP TCP Service Provider : 2 : 1 :  
 RSVP UDPv6 Service Provider : 2 : 2 : %SystemRoot%\system32\mswsock.dll 
 RSVP UDP Service Provider : 2 : 2 :  
 Hyper-V RAW : 2 : 1 : %SystemRoot%\system32\mswsock.dll
useragent_locale: en-US

This report also contains technical information about the state of the application when it crashed.
trevor-ratliff commented 9 years ago

the following article my explain why it broke in FireFox in version 44 https://blog.mozilla.org/addons/2015/10/14/breaking-changes-let-const-firefox-nightly-44/

After some light looking into the code there are instances of the let block that are affected. There was also some notes that the jpm builder needs to be updated and add-ons repackaged.

trevor-ratliff commented 9 years ago

repacking with a new version of jpm fixes the issues ... I don't know what kind of code may need to change in the future though

M-I commented 9 years ago

On mac, it doesn't do anything visible on Firefox 44.0a2 developer edition. No prompt for tiddlyfox access, no crash. Works fine on v42 stable.

trevor-ratliff commented 9 years ago

I'm running on windows 10 64bit processor, and yes v42 was fine, even v43 developer edition - but it broke in v44. I'm trying to repackage it locally to see if that works for this version of FireFox, but I'm having a hard time getting jpm to run under firefox developer edition 44 vs fire fox 42

trevor-ratliff commented 9 years ago

I've had success now running TiddlyFox in Firefox developer edition v44 on Windows 10 64 bit. It really was just re-packaging it in a new version of JPM. This doesn't brake it in older versions of Firefox. It would be nice if the developers/maintainers would bump the version and submit a freshly repacked extension to addons.mozilla.org

trevor-ratliff commented 8 years ago

update: the extension works well on tiddlyWiki files, however it does cause a browser crash when visiting Google sites if the extension is enabled ... not sure why that is yet.

buggyj commented 8 years ago

@trevor-ratliff have you tried with more recent ff releases?

trevor-ratliff commented 8 years ago

The developer edition recently changed to v46.0 and it doesn't seem to have the issue of crashing the browser, but I'm using a repackaged version I made a bit ago. I'll try the offical release today to see what it does.

Trevor

On Sat, Feb 6, 2016 at 3:35 AM buggyj notifications@github.com wrote:

@trevor-ratliff https://github.com/trevor-ratliff have you tried with more recent ff releases?

— Reply to this email directly or view it on GitHub https://github.com/TiddlyWiki/TiddlyFox/issues/35#issuecomment-180719719 .

trevor-ratliff commented 8 years ago

So far so good with the official TiddlyFox on developer v46. I'll keep you posted if I run into any trouble.

I've also updated my regular FireFox to v44 today to see if the issue still showed up there, but I'm not seeing the problem there yet either, so that's good news!

Trevor

On Mon, Feb 8, 2016 at 10:22 AM trevor ratliff trevor.w.ratliff@gmail.com wrote:

The developer edition recently changed to v46.0 and it doesn't seem to have the issue of crashing the browser, but I'm using a repackaged version I made a bit ago. I'll try the offical release today to see what it does.

Trevor

On Sat, Feb 6, 2016 at 3:35 AM buggyj notifications@github.com wrote:

@trevor-ratliff https://github.com/trevor-ratliff have you tried with more recent ff releases?

— Reply to this email directly or view it on GitHub https://github.com/TiddlyWiki/TiddlyFox/issues/35#issuecomment-180719719 .