JSHint Compliance

[Jermolene]

It would be desirable for the core code to pass JSHint without any warning messages. To do that we need to:

• Choose appropriate JSHint options for the project in a .jshintrc file
• Triage the warning messages according to whether the fix will require structural changes (eg, for problems like making functions within a loop)
  • Fix the simple things en masse
  • For the difficult things, figure out a reasonable testing approach for them
• Update .jshintignore file to exclude external libraries

See also #1865 which refers to using JCSC to enforce coding style guidelines; it's possible that some of the fixes that JCSC suggests will also assist JSHint compliance.

[sukima]

@Jermolene in order to properly audit with JSHint you need to establish which JSHint options the project wants adhere to. For example Ember.js uses this .jshinrc. And for comparison this for JCSC.

Also, :+1: would love this!

[Jermolene]

Thanks @sukima I've updated the ticket.

[pmario]

related to: Remove function wrapper / add matching dprint and eslint configurations #7596