Open tobibeer opened 8 years ago
Hi @tobibeer I think this would be rather a backwards incompatible change.
Instead, perhaps we should introduce a few useful, core CSS classes for standard core table styles to cover common use cases?
I think this would be rather a backwards incompatible change.
Not sure people do (or should) heavily rely on vertical align in tables (for layouting purposes)... but yes, it's possible. What I see mostly — when I see it — is the problematic behavior. So, a default change would probably fix more problems than it introduces.
Instead, perhaps we should introduce a few useful, core CSS classes for standard core table styles to cover common use cases?
Sure. How about table.tc-top
? Perhaps another also table.tc-borderless
?
Sure. How about table.tc-top? Perhaps another also table.tc-borderless?
I'm not sure it's worth a class just to encapsulation the top alignment. I was thinking of higher level classes, kind of like the choices one gets in PowerPoint. But combinations of classes could also work I guess.
I was thinking of higher level classes, kind of like the choices one gets in PowerPoint.
Yes, not necessarily just bound to table cells, of course. Just wanted to indicate that we'd have to be specific to cover certain table elements.
How about a subset of Eric's StyleSheetShortcuts?
How about a subset of Eric's StyleSheetShortcuts?
That's certainly one approach, and has the advantage of being tried and trusted. I had a look for open source libraries of different table themes, but could find anything. Most of the CSS frameworks that I looked at just support a single table style.
To be clear, we're just aiming at often used important defaults here. Right?
IMO TW (base and vanilla) should have an absolute minimum set of CSS default rules.
Something like StyleSheetShortcuts should be a plugin, theme or palette. Wherever it fits best.
Something like StyleSheetShortcuts should be a plugin, theme or palette. Wherever it fits best.
Surely neither a theme nor a palette. It could be wrapped up as a plugin, but then I'm not sure it's worth it. It appears to be rather a simple StyleSheet that is available independent / on top of any plugins, themes or palettes.
I'm not sure its purpose is to make amends for / overwrite otherwise problematic defaults like in the OP. I think "fixing" or changing those is independent from a simple css tiddler with meaningful base-classes.
So the options for #2018 seem:
Yes. Table defaults as in the OP should be part of "base" or "vanilla" CSS
In tb5, I define the default vertical alignment for table cells as...
Is there / what is the appropriate place to define default styles for all themes?
An example for the problem with the default:
With the proposed change...