Plugins that write text into the head section need two reloads to be installed (browser only)

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.

https://tiddlywiki.com/

Other

7.98k stars 1.18k forks source link

Plugins that write text into the head section need two reloads to be installed (browser only) #2159

Open buggyj opened 8 years ago

buggyj commented 8 years ago

This is a problem when using $:/tags/RawMarkup in a plugin.

this tag is used to insert a tiddlers text in the the head area of the html of the tiddlywiki - this happen when the tiddlywiki is saved. But when a plugin is first dropped into a tiddlywiki, its plugin tiddlers are not unpacked, so they will not be available to be inserted into the head. A reload is necessary to unpacked tiddlers from the plugins. This means this type of plugin will need to be saved and reloaded twice before it will work.

buggyj commented 8 years ago

My proposed solution is to access tiddlers tagged as $:/tags/RawMarkup from plugin tiddlers, thus even if the plugin in newly added and so has not been unplacked, these tiddlers can still be added to the head area of the tiddlywiki's html as it is saved.

In order to do this I propose extending the filter mechanism to use plugin tiddlers as a source (in place of the store) in filters, and thus leveraging the existing filter mechanism. The format could be:

[plugin[$:/plugin/anauthor/plugin]....rest of filter....

With this tool the 'saving' templates can be modified to include tiddlers that go into the html head area.

danielo515 commented 8 years ago

This is an important improvement for plugins that changes the wiki deeply.

@buggyj implementation seems fine to me.

danielo515 commented 8 years ago

Thank you very much @buggyj for this. It saved my life. Without this, the deployment of NoteSelf was absolutely impossible.

Hopefully this gets integrated into the core soon.

Regards

danielo515 commented 7 years ago

@buggyj why don't you make a pull request ? It's very hard to find this issue and your work every time I need it. It usually takes me more than 5 minutes, because I always think it was a pull request.

buggyj commented 7 years ago

Hi Daniel, unfortunately I do not have the time at the moment to have another look at this. Feel free to take the code and do with it as you wish,

On 14 June 2017 at 11:10, Daniel Rodríguez Rivero notifications@github.com wrote:

@buggyj https://github.com/buggyj why don't you make a pull request ? It's very hard to find this issue and your work every time I need it. It usually takes me more than 5 minutes, because I always think it was a pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Jermolene/TiddlyWiki5/issues/2159#issuecomment-308387118, or mute the thread https://github.com/notifications/unsubscribe-auth/ACuTc9QLbFCwQwOrAru_q2MLElc4AOESks5sD7GLgaJpZM4G7n_2 .