TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.05k stars 1.19k forks source link

Hebrew Translation Contribution #2523

Open DoronTzur opened 8 years ago

DoronTzur commented 8 years ago

Hi,

I'm new to TW5 but would like to try it with my students in Hebrew. I followed the translation instructions and here is a dropbox link to the translated tiddlers:

https://www.dropbox.com/s/ng19wthstrdb2y0/HEBTranslation.html?dl=0

I didn't fully understand your instructions regarding how the plugin itself is to be created so I would appreciate if you do this yourselves. I'll be happy to test the Hebrew version once this is done.

I'll also appreciate an update regarding RTL behavior in TW in general. I saw there was some discussion and I hope it soon becomes possible to work in RTL (and better still in mixed direction) natively.

Thanks for all the marvekous work you are doing and I'm looking forward to hearing back from you soon.

Best Regards,

Doron Tzur

Jermolene commented 8 years ago

Hi @DoronTzur thank you very much for the contribution, and welcome to the project.

I've unpacked the translation and added it as a new core plugin in this commit. You can preview it at:

http://tiddlywiki.com/prerelease/editions/full

You can use the updated translators edition to make any corrections:

http://tiddlywiki.com/prerelease/editions/translators

One small piece of bureaucracy: please could you send a pull request to add your name to the Contributor License Agreement. Click the edit button here:

https://github.com/Jermolene/TiddlyWiki5/blob/master/licenses/cla-individual.md

Many thanks

Jermolene commented 8 years ago

Apologies, I forgot to answer your questions...

I didn't fully understand your instructions regarding how the plugin itself is to be created so I would appreciate if you do this yourselves. I'll be happy to test the Hebrew version once this is done.

If you're adept at GitHub you are welcome to send pull requests direct to the repo, or I'm happy to unpack HTML files as in this case.

https://github.com/Jermolene/TiddlyWiki5/tree/master/languages/he-IL

I'll also appreciate an update regarding RTL behavior in TW in general. I saw there was some discussion and I hope it soon becomes possible to work in RTL (and better still in mixed direction) natively.

I haven't paid any attention to RTL support, I'm afraid, but it's something I'd very much like to support.

I'll do some reading, but would appreciate any of your thoughts on the things that you'd expect to change.

Jermolene commented 8 years ago

Hi @DoronTzur. I've been experimenting with better core support for RTL languages (see this commit), and would appreciate your comments. There's a prerelease build for you to try out at http://tiddlywiki.com/prerelease/editions/full - just select "Hebrew" from the language dropdown.

DoronTzur commented 8 years ago

Wonderful @Jermolene! Exciting to see the Hebrew version of TW materializing... However, after a quick look:

  1. When creating a new tiddler, an editor opens but can't add text in any text mode...
  2. BTW, There are rather few strings that I don't recall as being translatable -- e.g. Tiddler types.
  3. ControlPanel/Information/Default Tiddler -- Button is out of place although text was not translated and remained in English -- I suspect this would be typical to many similar areas mixing text and buttons.
pmario commented 8 years ago

@DoronTzur Editing seems to be possible, but the input cursor can't be seen. Just start typing after some chars you should see something :) .. @Jermolene Seems to be a CSS problem with codemirror editor.

pmario commented 8 years ago

@Jermolene codemirror has a setting for RTL languages. see: http://codemirror.net/doc/manual.html#config and search: rtlMoveVisually

So may be you disable this editor in the preview?

DoronTzur commented 8 years ago

@pmario , @Jermolene

  1. The editor indeed works but its rightmost part is invisible, This may be related to the additional actions (V sign) in Tiddler is also partly hidden on its right side.
  2. IMHO the editor should remain and if it can be set RTL, all the better.