search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.04k stars 1.19k forks source link

The Editor Toolbar Prevents Control Backspacing in Firefox #2532

Closed ghost closed 5 years ago

ghost commented 8 years ago

When the editor toolbar is open in a Tiddler hitting Ctrl+Backspace does nothing in the editor window. With the toolbar closed it deletes a whole word as expected. Checking the box in the settings menu immediately enables or disables use of Ctrl+Backspace.

Ctrl+Backspacing in other text fields, like TiddlyWiki search bar are unaffected.

Version: 5.1.13 Browser: Firefox (does not affect Chrome, other browsers are untested) OS: Windows 7 x64

-TCJ

rubaboo commented 8 years ago

Shift-Ins is another one: #2452.

mdemoss commented 5 years ago

I have the same problem, and I'm using the CodeMirror plugin as a work-around.

henrikh commented 5 years ago

I just tested this on 5.1.19 with Firefox 65.0b10 and the problem is not there.

Can someone else reproduce this?

henrikh commented 5 years ago

I've been trying to nail down where the issue is occurring and my current assumption is that the following function is where the event is canceled.

https://github.com/Jermolene/TiddlyWiki5/blob/929b0c98330ad25aa4a32cd201274a6e89cd8902/core/modules/editor/factory.js#L253

henrikh commented 5 years ago

I have just updated to Firefox 65 from the official release channel. The issue is no longer present at my end.

Jermolene commented 5 years ago

Thanks @henrikh

pmario commented 5 years ago

Hi, @ghost ... can you verify, that it works with latest FF 65. ... If yes please close the issue!

henrikh commented 5 years ago

@pmario Given that @ghost's user is deleted I don't think you'll hear a lot.

pmario commented 5 years ago

@Jermolene ... can you please close this issue?

Jermolene commented 5 years ago

Thanks @pmario @henrikh