Closed danielo515 closed 5 years ago
have a loot at: pluginreloadwarning.tid
haschanged
filter https://github.com/Jermolene/TiddlyWiki5/blob/master/core/ui/PageTemplate/pluginreloadwarning.tid#L6
Thanks @pmario You mean that it relies on TW filter and no JS logic is required here. Quite smart, but very rigid.
kind of. haschanged
imo is "js logic"
The language strings inside the plugin reload warning are already translatable, which I think is adequate configurability.
I have to admit that I like a lot the idea behind pluginreloadwarning.tid, but it is too tied to the core implementation.
In my opinion, it should be more configurable, for example, displaying the message of certain tiddler. That way, plugins requiring a page reload could use the reload warning.
It would be ideal if the core provides an interface to set the message and display the warning.
I'm curious about how it is triggered, I have searched across the entire wiki and I did not found it