search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.98k stars 1.18k forks source link

Introduce fallback storyview #2555

Closed twMat closed 8 years ago

twMat commented 8 years ago

I deleted a non-standard Storyview (+reload). This seems to result in no storyview active as indicated from no scrolling taking place when clicking titles and no storyview name seen in Ctrlpanel.

If the symptoms come from missing fallback and if it is cheap to introduce such (considering the edgyness of the case), then I propose to introduce Classic storyview as fallback default.

Jermolene commented 8 years ago

Hi @twMat you are correct; if $:/view is not set to the name of one of the currently loaded storyviews, then no storyview is used.

It's an easy fix. The new behaviour is that the storyview defaults to the classic storyview. However, the invalid value in $:/view is not fixed, so the storyview dropdown will still show no storyview selected.

twMat commented 8 years ago

Excellent. Thanks for fix!