TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.09k stars 1.19k forks source link

Proposal: replace macro call from $:/core/ui/TagTemplate with filter #3053

Closed angelodag closed 6 years ago

angelodag commented 6 years ago

In $:/core/ui/TagTemplate the list of the tiddlers tagged with a specific tag is created using the call:

<$macrocall $name="list-tagged-draggable" tag=<<currentTiddler>>/>

On the other end, the tiddlers displayed in the resulting list (accessible clicking on the tag pill) are NOT draggable. Same result may be achieves using a standard filter:

<$list filter="[all[current]tagging[]]">
<$link><$view field="title"/></$link>
</$list>

This approach also gives room for improvement i.e. customizing the filter to remove some results:

<$list filter="[all[current]tagging[]!tag[excludeLists]]">
 <$link><$view field="title"/></$link>
</$list>
pmario commented 6 years ago
{{xx||$:/core/ui/TagTemplate}}

I'm not sure what you tested. but for me, they are dragable. If you use the code above, and tag some tiddlers "xx" the resulting list is dragable.

So I don't see the need to change $:/core/ui/TagTemplate


<$list filter="[all[current]tagging[]!tag[excludeLists]]">

There was a reason, why we removed the excludeLists tag known from TWclassic. ... It cause way more problems than improvements.

angelodag commented 6 years ago

Hello Mario, thanks for the answer, I did check again and found that on Chrome/Chromium it works but it does not work on Internet Explorer (11), personally I use the HTA 'hack' and also in this case the dragging does not work.

Sorry I did not test with multiple browsers.

pmario commented 6 years ago

Did your proposal work with IE11? ... just to be sure.

pmario commented 6 years ago

Because, if it would work, it would be a strong reason to change it.