search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.02k stars 1.19k forks source link

Tight theme; river blocks sidebar #3312

Open twMat opened 6 years ago

twMat commented 6 years ago

theme: Tight theme + theme tweak: "fixed story/fluid sidebar"

...makes the story rivers (transparent) margins cover the sidebar so that the leftmost centimeter of the sidebar links are not clickable. The exact distance probably depends om screen size.

You can easily investigate this with this trick in the theme settings:

image

What I think happens, but I may be wrong, is that the sidebar has a margin: 0 0 0 -42px and it is fixedly positioned under the story river. The solution might be to have the tight theme deduct 2*42px from its river width.

(Side note: I never quite understood what the river width is to begin with, or at least what the point of it is, considering how it doesn't change anything visually...?)

Jermolene commented 6 years ago

Thanks @twMat this might make a good first pull request for somebody with some familiarity with CSS. The problem is an oversight in the adjustments made in the styles for the tight theme:

https://github.com/Jermolene/TiddlyWiki5/blob/master/themes/tiddlywiki/tight/base.tid

A reasonable approach would be to use the browser dev tools to examine what is different between the base "Snow White" theme and the "Tight" theme, and then try to figure out the oversight.

twMat commented 6 years ago

I'll have a look, hopefully within the next few days.