Range widget does not save value in IE10

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.

https://tiddlywiki.com/

Other

7.98k stars 1.18k forks source link

Range widget does not save value in IE10 #4519

Closed saqimtiaz closed 4 years ago

saqimtiaz commented 4 years ago

The range widget does not save its value on user mouse input in IE 10 on Windows 10.

To reproduce the bug:

Open https://tiddlywiki.com/#RangeWidget
Move the range widget sliders in the demos.
The new value is not displayed as the tiddler the value is to be saved to, is not created.

This is probably because IE 10 & 11 do not fire the input event on range sliders on mousemove, but rather the change event. See "Known Issues" at https://caniuse.com/#feat=input-range

Jermolene commented 4 years ago

Thanks @saqimtiaz do you have a fix?

saqimtiaz commented 4 years ago

Thanks @saqimtiaz do you have a fix?

I can attempt a fix in the next few days, I currently do not have a Windows test/debug environment and will need to set one up

Jermolene commented 4 years ago

Thanks. I don't pay much attention to IE10 but it's good to fix what we can for IE11

saqimtiaz commented 4 years ago

@Jermolene I believe this is the simplest solution and doesn't require resorting to browser sniffing: https://github.com/Jermolene/TiddlyWiki5/pull/4534