new syncer: minor problem with "offline snapshot" - wrong favicon

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.

https://tiddlywiki.com/

Other

8.06k stars 1.19k forks source link

new syncer: minor problem with "offline snapshot" - wrong favicon #4529

Open pmario opened 4 years ago

pmario commented 4 years ago

To reproduce:

open edition tw5.com-server
Save "snapshot for offline use"
Open this snapshot wiki
-> It has a "red" favicon instead of a "blue" one, which is needed for a file-tw.

syncer-wrong-favicon

Who can tell, which one is the "network tab"?

Jermolene commented 4 years ago

Hi @pmario the blue favicon isn't part of the core plugin, so we can't fall back to it by excluding $:/favicon.ico from the snapshot.

pmario commented 4 years ago

I did read somewhere, that all browsers now support SVG favicons. ... But I can't find the info now.

So it may be possible, to have SVG favicons, which we could style with CSS.

Jermolene commented 4 years ago

Interesting. Looking at https://caniuse.com/#feat=link-icon-svg it looks like it's Firefox and Chromium only at this stage:

pmario commented 4 years ago

Yea, Also had a look there. ... So will need some more time :/

pmario commented 4 years ago

The "default" TW favicon is 100kByte and 128x128 in size. ... IMO only 32x32 pixel (6kByte) are needed?

The TW server has a GET favicon function. .. So it may be possible to "lazy-load" it, when the snapshot is saved. ... Just brainstorming.

Jermolene commented 4 years ago

The default TW icon actually contains four differently sized images, 16x16, 32x32, 64x64 and 128x128. You might need to open it in an app that specifically supports the layers in .ico files. The reason for the large sizes is that several browsers display the full sized favicon in contexts other than the tab bar.

pmario commented 4 years ago

OK I see.