TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.05k stars 1.19k forks source link

[IDEA] translink macro style should be use css classes, not be inline. #4877

Open amreus opened 4 years ago

amreus commented 4 years ago

The translink macro uses inline styles but should use css classes to allow users to style them using a Stylesheet. Also, the thick black borders are out of character with the rest of the default styles.

2020-10-04_075437

KendrickLamarck commented 4 years ago

Piggybacking off of this to say some semi-related things:

Firstly, there is a typo in the macro definition: In two places it says foreground; white; instead of foreground: white; (same with black later on).

Secondly, I agree with you, but I also don't think the macro should ever be used. The same functionality can easily be achieved with transclusion through a template. It also isn't documented. The only purpose it currently seems to serve is as the default macro for the excise operation.

mateuszwilczek commented 1 year ago

@Jermolene this can be closed now, it somehow didn't automatically get closed by being mentioned in description of #7425

Jermolene commented 1 year ago

Thank you @mateuszwilczek @KendrickLamarck @amreus