search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.98k stars 1.18k forks source link

markdown.js does not render tables on 5.0.14-beta #743

Closed fullaware closed 10 years ago

fullaware commented 10 years ago

TiddlyWiki version 5.0.14-beta OS: OSX 10.9.4 Browser: Firefox 31.00 Installed plugin today: Aug 20, 2014 Plugin source: http://tiddlywiki.com/markdowndemo.html#%24%3A%2Fplugins%2Ftiddlywiki%2Fmarkdown

Image of issue: screen shot 2014-08-20 at 7 49 38 am

Jermolene commented 10 years ago

Hi @fullaware TiddlyWiki uses the markdown.js plugin from @evilstreak: https://github.com/evilstreak/markdown-js

By default, it only supports Gruber's standard Markdown core, which doesn't include support for tables. It appears that more recent versions of markdown.js support pluggable "dialects", one of which "Maruku" does include table support. I'll investigate upgrading and enabling the alternative dialect support.

fullaware commented 10 years ago

@Jermolene Thanks for your hard work!

evilstreak commented 10 years ago

I think the Maruku dialect was shipped with markdown-js from the start, but support for tables was only added in version 0.5. It's very compatible with Gruber-style markdown, so should be pretty simple to get it turned on.

Jermolene commented 10 years ago

Thanks @evilstreak much appreciated (great project too btw). I'm adding a configuration option to the TiddlyWiki core for specifying the dialect.

@fullaware - I've done more tests and it appears to me that table support is enabled by default at http://tiddlywiki.com/markdowndemo.html. I added a new tiddler with the following content and it was rendered correctly as a table:

|Tables |Are |Cool |
|All |The |Time |
Jermolene commented 10 years ago

@fullaware - I've done more tests and it appears to me that table support is enabled by default at http://tiddlywiki.com/markdowndemo.html. I added a new tiddler with the following content and it was rendered correctly as a table:

@fullaware apologies, due to general woolly headedness I was of course testing with a TW5-syntax tiddler, rather than a markdown tiddler.

I've added a configuration tiddler that allows the dialect to be configured. Setting it to "Maruku" enables table support:

https://github.com/Jermolene/TiddlyWiki5/commit/32b795452ff07a886776f71ac75117c859cc2189

fullaware commented 10 years ago

@Jermolene you totally rock!

Jermolene commented 10 years ago

@fullaware - Thank you!

What we need now is an army of TiddlyWiki evangelists spreading the word :)

fullaware commented 10 years ago

My dozens of followers will hear my testimony: https://plus.google.com/109122720735836844970/posts/JpoqM7BedR3

Jermolene commented 10 years ago

Thanks @fullaware!

fullaware commented 10 years ago

@Jermolene any chance this could be released soon? Not really one for rolling from repo for something that is a critical part of my workflow :)

Jermolene commented 10 years ago

@fullaware if all goes well 5.0.16 will be released in the next 24 hours.

fullaware commented 10 years ago

@Jermolene you do not rest and we are all the better for it.

Dahaniel commented 6 years ago

Found this old thread while looking for help with tables. Tables are not rendering for me in Markdown Tiddlers in Tiddlywiki 5.1.15. I tested both dialects with no luck.

uplight-dev commented 5 years ago

@Dahaniel - works fine only with Maruku dialect in 5.1.20:

Header Another header
field 1 something
field 2 something else