TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.09k stars 1.19k forks source link

[IDEA] Change "save" button to indicate that change is in progress #7921

Open Marxsal opened 10 months ago

Marxsal commented 10 months ago

Reference:

https://talk.tiddlywiki.org/t/on-slow-save-turn-save-button-yellow-while-saving/8845

Is your feature request related to a problem? Please describe.

When the save process starts can we change the save button to yellow to indicate it is in the saving process? Then when the save process is done the save button turns gray again like normal.

I don’t know anyone else who has this problem but this is a non-stop problem for me. I don’t want to accidentally click the save button again in the middle of a save because, in the past, TW has given me an error.

Describe the solution you'd like

Change the colour, shape, or "action" of the save button to indicate that a save is still in progress.

Additional context

Some operating systems, or network drives have long save times, perhaps due to virus-scanning.

Comment by Jeremy:

Hi @C_Bacca I agree that it would be useful to be able to have an indicator that a save is in progress. I looked briefly at the code for $:/core/modules/saver-handler.js and it looks feasible to set an additional class on the root element while a save is in progress, which would allow us to colour the icon orange during the save. Perhaps somebody could create a GitHub ticket to keep track of the idea?

Jermolene commented 10 months ago

Thanks @Marxsal

I think this could be a good introductory PR for someone to work on.

bulrush15 commented 10 months ago

Yes please! Because it takes my TW 40+ seconds to save in my odd configuration. I don't know why and I haven't been able to fix it. I need to use TW in a browser and am unable to install other software to support TW. And Brave/Chromium browser is the only one I can get to save the file.

When I'm saving I sometimes hit the save button again and get an error. I don't want to hose my TW file.